ndk-build,cargo-apk: Launch activity directly through ndk-gdb
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ndk-gdb` passes `-D` to `am start` to make the process wait until the debugger is launched and ready, instead of possibly crashing the app before the debugger can catch it (paired with a nice "waiting for debugger" dialog and "Force close" button in Android). While we could also set the flag ourselves, this change simplifies the workflow on our end as well now that we don't have to run our own command, potentially get stuck on `pidof` returning multiple PIDs, and having to override `no_logcat` (#342). (For the multiple-PID case though, we can optionally pass `-f` to make `ndk-gdb` kill the debugger and app first, if this ever becomes an issue.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ndk-gdbpasses-Dtoam startto make the process wait until the debugger is launched and ready, instead of possibly crashing the app before the debugger can catch it (paired with a nice "waiting for debugger" dialog and "Force close" button in Android). While we could also set the flag ourselves, this change simplifies the workflow on our end as well now that we don't have to run our own command, potentially get stuck onpidofreturning multiple PIDs, and having to overrideno_logcat(#342).(For the multiple-PID case though, we can optionally pass
-fto makendk-gdbkill the debugger and app first, if this ever becomes an issue.)