Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the ModifiersChanged event handling #2768

Open
kchibisov opened this issue Apr 12, 2023 · 1 comment
Open

Adjust the ModifiersChanged event handling #2768

kchibisov opened this issue Apr 12, 2023 · 1 comment
Labels
S - api Design and usability

Comments

@kchibisov
Copy link
Member

The spec got one more "clarification" lately wrt the keyboard modifiers. Given that our ModifiersChanged event is tied to Focus state, as in on leave we don't have focus and on regaining focus we have modifiers back on.

For winit's event API it simply means that we should send the ModifiersChanged event along side the PointerEnter and PointerLeave events. I'm not sure whether it's a breaking change, but it's something we should consider once we land the #2662 (Keyboard input v2).

The backends should start sending this event when pointer enters the surface of the window, as well as sending it again on keyboard enter/leave.

The good thing is that we still assume the empty state when losing, but then compositor should send the modifiers event again to tell us about the pointer focus. Usually compositors will send
such events related to pointer and keyboard focuses, so we should have internal seat focus inside
the Wayland backend.

For more see:

https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/259

@kchibisov kchibisov added S - api Design and usability P - high Vital to have labels Apr 12, 2023
@kchibisov kchibisov added this to the Version 0.29.0 milestone Apr 12, 2023
@kchibisov kchibisov removed the P - high Vital to have label Feb 3, 2024
@kchibisov
Copy link
Member Author

Hm, hard to find compositor that actually does so to test. Will move to 0.31 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S - api Design and usability
Development

No branches or pull requests

1 participant