Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special treatment of jack_get_cycle_times #163

Closed
wmedrano opened this issue Feb 5, 2022 · 1 comment
Closed

Remove special treatment of jack_get_cycle_times #163

wmedrano opened this issue Feb 5, 2022 · 1 comment

Comments

@wmedrano
Copy link
Member

wmedrano commented Feb 5, 2022

jack_get_cycle_times is loaded with libloading. It's possible to remove special treatment and move it into an external_library! as well.

Bonus: Add all appropriate configurations in GitHub Actions to test that everything works out fine. Ideally we want to test Linux, Mac, Windows, ARM, x86, Jack 1 & 2, and new JACK versions and old.
@wmedrano wmedrano mentioned this issue Feb 5, 2022
Merged
@Be-ing
Copy link
Contributor

Be-ing commented Feb 5, 2022

Bonus: Add all appropriate configurations in GitHub Actions to test that everything works out fine. Ideally we want to test Linux, Mac, Windows, ARM, x86, Jack 1 & 2, and new JACK versions and old.

Chocolatey could be used to install JACK on Windows. Homebrew could be used to install it on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmedrano @Be-ing