Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdesk-server doctor #88

Merged
merged 2 commits into from Sep 19, 2022
Merged

rustdesk-server doctor #88

merged 2 commits into from Sep 19, 2022

Conversation

paspo
Copy link
Contributor

@paspo paspo commented Aug 6, 2022

I added a small util to be run on a client machine to test for connectivity problems.

Example:

$ rustdesk-server doctor myrelay.rustdesk.com
Checking server:  myrelay.rustdesk.com

Found 1 IP addresses: 
 - 123.456.123.456

Checking IP address: 123.456.123.456
Is IPV4: true
Is IPV6: false
Reverse DNS lookup: 'vps444.provider.com' DOESN'T MATCH server address 'myrelay.rustdesk.com'
TCP Port 21114 (API): OK in 25 ms
TCP Port 21115 (hbbs extra port for nat test): OK in 21 ms
TCP Port 21116 (hbbs): OK in 21 ms
TCP Port 21117 (hbbr tcp): OK in 21 ms
TCP Port 21118 (hbbs websocket): OK in 24 ms
TCP Port 21119 (hbbr websocket): OK in 21 ms

I would like to add some more checks, like:

  • ICMP ping (maybe not needed)
  • key support (key required or not, check if a provided key is valid)
  • client register test
  • relay functionality test

As always, this is the first time I use rust, so I need vetting.

Please comment.

src/utils.rs Outdated Show resolved Hide resolved
@paspo
Copy link
Contributor Author

paspo commented Aug 8, 2022

  • ICMP ping (maybe not needed)
  • key support (key required or not, check if a provided key is valid)
  • client register test
  • relay functionality test

@rustdesk I need feedback on these ideas.
Does they make sense?
How can they be implemented? (I just need you to point me in the right direction, I hope I can figure out the rest)

But more important: the tests already done (DNS check, TCP ports) already covers the big part of self-hosted user problems, so we can publish these changes and leave the ideas for the future.

If you're ok, we should probably include the rustdesk-utils binary in classic docker images also.

@paspo paspo marked this pull request as ready for review August 9, 2022 08:15
@paspo
Copy link
Contributor Author

paspo commented Sep 19, 2022

@rustdesk can you take a look on this? I really need your feedback.

@rustdesk
Copy link
Owner

good job, you are good at rust now.

@rustdesk rustdesk merged commit 85af668 into rustdesk:master Sep 19, 2022
@paspo paspo deleted the doctor branch September 20, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants