Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry screen [nightly] #2180

Closed
KoalaBear84 opened this issue Nov 17, 2022 · 24 comments · Fixed by #2212
Closed

Blurry screen [nightly] #2180

KoalaBear84 opened this issue Nov 17, 2022 · 24 comments · Fixed by #2212
Labels
bug Something isn't working

Comments

@KoalaBear84
Copy link
Contributor

Describe the bug you encountered:

The 'remote' screen is blurry. It looks like it's depending on the odd or even height of the RustDesk window, and maybe also the width.

rustdesk_2022-11-17_08-05-11.mp4

image

What did you expect to happen instead?

Always clear screen when no scaling.

How did you install RustDesk?

RustDesk version and environment

Latest nightly on this repo, just run.

Host
Windows 10 Enterprise 22H2 (OS Build 19045.2251)
GitHub release, latest nightly of 7 hours ago

Client
Windows 10 Pro 21H2 (OS Build 19044.2251)
@Kingtous nightly release, installed.

@KoalaBear84 KoalaBear84 added the bug Something isn't working label Nov 17, 2022
@rustdesk
Copy link
Owner

@fufesou

@fufesou
Copy link
Collaborator

fufesou commented Nov 17, 2022

Thanks. @KoalaBear84
I can't reproduce this problem. But I almost know where the problem is. I'll read the dev doc the make the picture better.

@KoalaBear84
Copy link
Contributor Author

Great. Not sure if it has anything to do with the screen sizes.

Host: 2560 x 1440
Client: 1920 x 1200

@rustdesk
Copy link
Owner

If even number has better quality, we can always scale to even width/height, remaining one pixel as padding. let's test first, and also try painting argument adjustment first.

@fufesou
Copy link
Collaborator

fufesou commented Nov 18, 2022

@KoalaBear84 Hi, would you please try to test if it is blured when you only change the height or width of the window?
The picture is kept aspect ratio. Changing height may not cause rescaling if window width is not big enough.
I just want to make sure if the problem exists without rescaling the picture.

@KoalaBear84
Copy link
Contributor Author

KoalaBear84 commented Nov 18, 2022

I hope this is the information you are looking for. At first the Rustdesk window is larger than the clients window, but it still blurs it. And also after the RustDesk window is smaller than the clients desktop, it keeps on blurring.

rustdesk_rd3uzIWGsT.mp4

@rustdesk
Copy link
Owner

rustdesk commented Nov 18, 2022

bluring is expected if picture is scaled. Please compare with 1.1.9 with the same scale, which has worse bluring.

@fufesou
Copy link
Collaborator

fufesou commented Nov 18, 2022

It seems you are testing with orignal scale. Can you help make sure the option "Scale original" or "Scale adaptive"? Which one causes blurring or both?
image

@fufesou
Copy link
Collaborator

fufesou commented Nov 18, 2022

Thanks. I've reproduced this problem. The picture is blured while it is not scaled.

@rustdesk
Copy link
Owner

flutter/flutter#115653

@fufesou
Copy link
Collaborator

fufesou commented Nov 18, 2022

@KoalaBear84 Hi, would you please try if this problem is fixed on your env?
https://github.com/fufesou/rustdesk/releases/tag/nightly
The build action is almost done.
https://github.com/fufesou/rustdesk/actions/runs/3497958692

@KoalaBear84
Copy link
Contributor Author

Just tested it again with the newest nightly of ~7 hours ago, removed the old version, installed the newest. Same issue. But now also flickering, I think that wasn't there before but might be because of switching the modes.

msedge_8YDMbR43vb.mp4

@rustdesk
Copy link
Owner

again

:(

@rustdesk rustdesk reopened this Nov 21, 2022
@fufesou
Copy link
Collaborator

fufesou commented Nov 21, 2022

@KoalaBear84 Hi, nightly build is not correct today. We're generating new nightly build. Please try later after the action is done.
https://github.com/rustdesk/rustdesk/actions/runs/3512742639

@KoalaBear84
Copy link
Contributor Author

Latest nightly generated version of 30 minutes ago is working as expected 👍

@severach
Copy link

It's not fixed for me.

Both Linux local and Windows remote have been updated to latest nightly or git.

[x] Scale Original
[x] Good Image Quality

Fullscreen is perfect. When not not full screen as maximized or small window gives fuzzy text. Moving the mouse which moves the remote screen changes the location of the fuzziness. Adjusting the size of the window also changes the fuzziness including when the local window is larger than the remote screen.

The local local screen is 1920x1200.

This screenshot is from a Windows remote at 1600x900. I sized the local window, always larger than the remote screen, until I got the fuzz to be really bad. When I adjust the local window client area to exactly 1600x900 the quality is perfect.

Screenshot from 2022-11-24 19-15-38

Any local window size equal to or larger than the remote screen should have no effect on image quality. With Scale Original no window size should have any effect on image quality.

This screenshot is from a Windows remote at 1920x1200 where the local window size has been reduced to maximize poor quality and clipped text.

Screenshot from 2022-11-24 18-39-33 Rustdesk

@fufesou
Copy link
Collaborator

fufesou commented Nov 25, 2022

flutter/flutter#115653

@severach Thank you for your detailed feedback.
Is "Scale Adaptive" work fine?
I'll test LInux --> Win, but I can't promise to fully fix this issue.

@rustdesk rustdesk reopened this Nov 25, 2022
@severach
Copy link

Scale Adaptive is better and is as good as can be expected with non integer scaling.

The Windows client is no better than Linux.

It's definitely Flutter. I reworked rustdesk-git from build.py to produce Flutter or Sciter. I switched the local client to Linux Sciter and now the text looks good at any resize larger or smaller. The the remote server is still running Windows Flutter. You don't offer a Windows Sciter nightly. I switched my Windows client back to the Sciter built 1.1.9 and text looks good there too.

For Sciter, no more auto mouse scroll for small windows and the vertical scrollbar seems missing.

The Flutter thread mentioned that some resolutions didn't exhibit the problem. I tried all I have on this Lenovo LT2452: 800x600,1024x768,1280x720,1440x900,1280x1024,1680x1050,1600x1200,1920x1080,1920x1200. No resolution showed clear text. Some resolutions were much worse, possibly due to changing the numerics of the Flutter bug or possibly because the monitor's non integer scaling makes everything worse. Native OS windows always looked much better than the remote window.

@rustdesk
Copy link
Owner

rustdesk commented Nov 25, 2022

@fufesou scrollbar mode of Sciter version needs to be tested, win32bit still use it, we need to make it work.

@fufesou
Copy link
Collaborator

fufesou commented Nov 29, 2022

@severach Hi, sciter version does not support auto mouse scroll now.
I've tested sicter version. I can see both vertical and horizental scrollbars.

explorer_1z483eYhU6.mp4

@fufesou
Copy link
Collaborator

fufesou commented Nov 29, 2022

@fufesou
Copy link
Collaborator

fufesou commented Nov 30, 2022

@severach Hi, I've push the PR to fix this issue. Can you please download the nightly and test tommrow?
#2395

@severach
Copy link

severach commented Nov 30, 2022

The patch was in time for the nightly. Linux git and Windows nightly look good.

@severach
Copy link

severach commented Dec 5, 2022

Blurry is fixed. Please close.

@rustdesk rustdesk closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants