Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly parse custom configuration with nested HTML comments #14

Open
JeanMertz opened this issue May 4, 2020 · 0 comments · May be fixed by #22
Open

correctly parse custom configuration with nested HTML comments #14

JeanMertz opened this issue May 4, 2020 · 0 comments · May be fixed by #22
Labels
bug Something isn't working

Comments

@JeanMertz
Copy link
Member

While investigating #13, I noticed that the default template has nested HTML comments at line 68 and 84.

This causes the config parser to break If you copy this template verbatim into your CHANGELOG.md.

The parser should handle nested HTML comments by counting open/close comment markers, and only stop parsing once the root marker is closed.
@JeanMertz JeanMertz added the bug Something isn't working label May 4, 2020
@JeanMertz JeanMertz mentioned this issue Aug 16, 2020
Closed
@jcgruenhage jcgruenhage linked a pull request Sep 3, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle nested HTML tags in the config jcgruenhage/jilu
1 participant
@JeanMertz