Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RUSTIC_HOME and update precedence for platform specific app directories #859

Open
2 tasks done
simonsan opened this issue Aug 30, 2023 · 7 comments · May be fixed by #1059
Open
2 tasks done

Add RUSTIC_HOME and update precedence for platform specific app directories #859

simonsan opened this issue Aug 30, 2023 · 7 comments · May be fixed by #1059
Labels
A-meta Area: Project wide A-ui-ux Area: Related to user interfaces and user experience C-enhancement Category: New feature or request

Comments

@simonsan
Copy link
Contributor

simonsan commented Aug 30, 2023 •
edited
Loading

it gives the possibility to set a location of their own to the users.

yeah, users can set a custom location with the environment variable, but "RUSTIC_HOME": "$dir" is defined in manifest, $env:RUSTIC_HOME will be reset to $dir every update.

If you want to make the program more portable. rustic_home should be set in order and fallback to the first existing path:

  1. $env:RUSTIC_HOME
  2. <program_root>\home
  3. $env:USERPROFILE\.config\rustic or $env:USERPROFILE\.rustic
  4. $env:APPDATA\rustic
  5. $env:ProgramData\rustic
    ...

note, this just a example or suggestion, or a feature request for your project.

Originally posted by @HUMORCE in ScoopInstaller/Main#5042 (comment)

Furthermore, we need to make sure, that the next release:
@simonsan simonsan added C-bug Category: Something isn't working as expected A-ci Area: Issues/Pull requests related to CI O-windows Operating system: Windows C-upstream Category: Issue for a dependency, will be fixed upstream A-meta Area: Project wide A-packaging Area: related to packaging labels Aug 30, 2023
@tech189
Copy link

tech189 commented Jan 19, 2024

Hi, just to let you know, the latest release (0.6.1) doesn't contain any binaries for Windows so the Scoop package is out of date currently.

@simonsan
Copy link
Contributor Author

Yes, the last release didn't contain a windows binary (@aawsome), we need to investigate that, fortunately we will have another release soon. Thank you a lot for the heads-up, though!

@simonsan
Copy link
Contributor Author

simonsan commented Feb 3, 2024

Hi, just to let you know, the latest release (0.6.1) doesn't contain any binaries for Windows so the Scoop package is out of date currently.

With the new release, packages should be updated, hashes are attached and packages are signed. So we should be able to update our scoop package at this point.

@simonsan
Copy link
Contributor Author

simonsan commented Feb 4, 2024 •
edited
Loading

Hash for rustic has been updated: ScoopInstaller/Main#5494

I'm not sure, why it didn't get automatically updated, though. Might need further investigation.

@simonsan
Copy link
Contributor Author

simonsan commented Feb 4, 2024

Update: The hash has been updated, but because I needed to rebuild the artifacts once again when I discovered the internal hierarchy was breaking self-update, the CD updated the attached artifacts on the release, which didn't get to the scoop CI (hook runs only first time when a release is published).

@simonsan simonsan changed the title packaging: scoop manifest and CI needs update Add RUSTIC_HOME and update precedence for platform specific app directories Feb 4, 2024
@simonsan simonsan added C-enhancement Category: New feature or request A-ui-ux Area: Related to user interfaces and user experience and removed C-bug Category: Something isn't working as expected A-ci Area: Issues/Pull requests related to CI O-windows Operating system: Windows C-upstream Category: Issue for a dependency, will be fixed upstream A-packaging Area: related to packaging labels Feb 4, 2024
@simonsan simonsan linked a pull request Feb 11, 2024 that will close this issue
Open
@simonsan
Copy link
Contributor Author

simonsan commented Feb 11, 2024 •
edited
Loading

yeah, users can set a custom location with the environment variable, but "RUSTIC_HOME": "$dir" is defined in manifest, $env:RUSTIC_HOME will be reset to $dir every update.

We need to think that through, as that could become a problem. We may only set RUSTIC_HOME in scoop if it's unset. On the other hand, it could also lead to issues, to not reset it on an update, as people could copy their executable from their scoop directory to use it from another folder. After updating, they would think, they are using the updated version — but they aren't because RUSTIC_HOME still points to their rustic custom folder using their configs. Which could lead to weird bug reports down the line.

@tech189 Is there a usual way to handle that for scoop manifests?

@tech189
Copy link

tech189 commented Feb 18, 2024

Installations of apps with Scoop are not meant to be portable as far as I know. Users should know that if they move executables away from their Scoop directory, they will no longer be managed by Scoop and updates/environment variables will no longer work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-meta Area: Project wide A-ui-ux Area: Related to user interfaces and user experience C-enhancement Category: New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(env): Make rustic more portable simonsan/rustic
2 participants
@tech189 @simonsan