Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shellwords to split strings #752

Merged
merged 2 commits into from Aug 16, 2023
Merged

use shellwords to split strings #752

merged 2 commits into from Aug 16, 2023

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Jul 16, 2023

No description provided.

@simonsan
Copy link
Contributor

Shell-words:
Last release is over a year ago on Feb 6, 2022.
PRs that are not merged are from August 2022: https://github.com/tmiasko/shell-words/pulls

Not sure if this change is needed?

@aawsome
Copy link
Member Author

aawsome commented Jul 16, 2023

I came to shell_words by realizing that we already have it as dependency (in rustic, as dialoguer depends on it) and that it in fact solves the problem I tried to solve by the nom crate. It does so even better as the current solution doesn't support and handle \" in strings. So it is both an improvement and simplifies dependencies (a bit).
I'm open to exchange it with something else if there is a better choice! If not, I would just use it as the very popular dialoguer crate also uses it...

@simonsan simonsan added the C-refactor Category: Refactoring of already existing code label Jul 16, 2023
@simonsan simonsan added the S-waiting-for-review Status: PRs waiting for review label Aug 16, 2023
@simonsan simonsan removed the S-waiting-for-review Status: PRs waiting for review label Aug 16, 2023
@simonsan simonsan merged commit ae8bb21 into main Aug 16, 2023
19 checks passed
@simonsan simonsan deleted the shellwords branch August 16, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactoring of already existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants