Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#950: Enable RPM file build target #951

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

troelsarvin
Copy link
Contributor

@troelsarvin troelsarvin commented Nov 20, 2023

For #950: If one has "cargo-generate-rpm" installed, then this makes it easy to create an RPM file from the result of a release build. If one doesn't have "cargo-generate-rpm" installed, the extra Cargo.toml lines don't make a difference.

closes #950

Cargo.toml Outdated Show resolved Hide resolved
@troelsarvin
Copy link
Contributor Author

Oups, sorry about that typo; PR updated.

aawsome
aawsome previously approved these changes Nov 20, 2023
Copy link
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - maybe this can be later extended to add example configuration files or some docu or generated shell completions. But we can start simple ;-)

@simonsan
Copy link
Contributor

Can you format it with dprint, please? Then the CI will run through. 👍🏽

@troelsarvin
Copy link
Contributor Author

Cargo.toml as been through "dprint fmt" now.

@aawsome aawsome added this pull request to the merge queue Nov 20, 2023
Merged via the queue into rustic-rs:main with commit bfbc9b4 Nov 20, 2023
25 checks passed
@simonsan
Copy link
Contributor

Thank you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable easy RPM file building
3 participants