Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging optional #20

Closed
anna-is-cute opened this issue May 17, 2017 · 3 comments
Closed

Make logging optional #20

anna-is-cute opened this issue May 17, 2017 · 3 comments

Comments

@anna-is-cute
Copy link

Reference to rustls/rustls#22.

Having log be an optional crate is great in rustls. However, this crate depends on rustls with no way to turn off logging, which really, really looks bad in binary crates (especially since rustls prints out all of this debug info in the INFO log level instead of DEBUG).

Please either make logging an option here or turn it off.

@lucab
Copy link
Contributor

lucab commented Jun 1, 2017

However, as logging is a default feature of rustls, in order to turn it off you'll need to go after every single dependency of your project and convince them to opt-out or expose a feature. I don't think this will scale out well. Some alternatives could be:

@anna-is-cute
Copy link
Author

Making logging non-default in rustls would be good, as this is generally what's expected of that kind of library, and I'm surprised this isn't already the case.

Having rustls = { version = "whatever", no-default-features = true } is still possible in this crate, as well. Can definitely have a feature that enables it or disables it, as well.

@g2p
Copy link
Contributor

g2p commented Nov 15, 2021

Fixed in #156

@rustls rustls locked and limited conversation to collaborators Nov 15, 2021
@rustls rustls unlocked this conversation Nov 15, 2021
@djc djc closed this as completed Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants