Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.25 release, update to Rustls v0.22 #249

Closed
cpu opened this issue Jan 4, 2024 · 5 comments
Closed

Prepare v0.25 release, update to Rustls v0.22 #249

cpu opened this issue Jan 4, 2024 · 5 comments

Comments

@cpu
Copy link
Member

cpu commented Jan 4, 2024

This issue collects up preparation work for a hyper-rustls 0.25 release, bringing in the update to Rustls 0.22

Since main has already had its Cargo.toml version updated this is an issue instead of a pull-request.

Resolves #247

Proposed Changelog

  • The Rustls dependency has been updated to 0.22
  • The acceptor module is now public.
  • The TlsStream type now has io and connection accessor methods for getting a reference to the underlying I/O stream and rustls::ServerConnection.
  • A new AcceptorBuilder::with_connector method is added for taking a generic acceptor implementing Accept.
  • ConnectorBuilder::enable_all_versions has been fixed to advertise the correct ALPN values based on enabled crate features.
  • ConnectorBuilder::with_native_roots has been updated to be fallible, allowing a failure to load native roots to be handled by the caller instead of producing a panic.
@cpu
Copy link
Member Author

cpu commented Jan 4, 2024

@djc @ctz Would you folks mind +1ing the proposed changelog in comments here? There wasn't a code change to merit a pull request but it makes the "approval" of this proposed release a little awkward :-)

@ctz
Copy link
Member

ctz commented Jan 4, 2024

Looks complete to me!

@djc
Copy link
Member

djc commented Jan 4, 2024

  • The Acceptor module is now public and has io and connection accessors fns for getting a reference to the underlying I/O stream and rustls::ServerConnection.

I find "The Acceptor module" confusing, since that doesn't look like a module name? And you didn't link the PR here and I'm too lazy to dig up the PR right now. Also "accessors fns" I would probably write as "accessor functions" or "accessor methods" maybe. Maybe the rustls dependency update should move to the top of the list?

👍 modulo these nits.

@cpu
Copy link
Member Author

cpu commented Jan 4, 2024

I find "The Acceptor module" confusing, since that doesn't look like a module name?

Good catch, that should be acceptor not Acceptor. Fixed.

And you didn't link the PR here and I'm too lazy to dig up the PR right now.

That one is #219 The PRs will be linked from the GitHub generated changelog for the final release notes so I didn't source them for the proposed text.

Also "accessors fns" I would probably write as "accessor functions" or "accessor methods" maybe.

I split this out into a line about the acceptor module being public, and a separate line about TlsStream getting the new accesor methods.

Maybe the rustls dependency update should move to the top of the list?

Done.

Thanks for the review 👍

@cpu
Copy link
Member Author

cpu commented Jan 4, 2024

@cpu cpu closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants