Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust minimum version should be updated #258

Closed
hhartzer opened this issue Mar 14, 2024 · 4 comments
Closed

Rust minimum version should be updated #258

hhartzer opened this issue Mar 14, 2024 · 4 comments

Comments

@hhartzer
Copy link

Hi,

It looks like some new Rust features are being used, causing the build to fail for me in a less than intuitive way. 1.74 is too old, so I assume 1.75 or 1.76 is the minimum version. I know little of Rust, but I think this is easy to set in Cargo.toml, and currently is but to something much older.

Thanks!

Related: astral-sh/uv#2442

@hhartzer
Copy link
Author

It sounds like there might be a way to automate/test for this already. Not certain if this will be useful, but it looks like it might be so I'll share it.

@cpu
Copy link
Member

cpu commented Mar 14, 2024

Hi there,

This crates minimum supported rust version is 1.64 (https://github.com/rustls/hyper-rustls/blob/main/Cargo.toml#L5) so your Rust version should be OK.

We test this Rust version in our CI as well: https://github.com/rustls/hyper-rustls/blob/main/.github%2Fworkflows%2Fbuild.yml#L83-L97

Are you sure the compilation error you are getting with uv is from this crate? The error in your linked issue looks to me to be from a crate named 'pubgrub':

error[E0562]: impl Trait only allowed in function and inherent method return types, not in trait method return types
--> /root/.cargo/git/checkouts/pubgrub-4eebf9758cb3b340/addbaf1/src/solver.rs:264:30

@hhartzer
Copy link
Author

Aw, my bad. I think you are right! Thank you for setting me on the right path.

It looks like the installation is multi-threaded or something, so the order wasn't what I was expecting.

@cpu
Copy link
Member

cpu commented Mar 14, 2024

Happy to help :-) Cargo installs dependencies in parallel by default and it's easy to mix up the output.

@djc djc reopened this Mar 14, 2024
@djc djc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants