Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is async-std within the scope of this crate? #97

Open
CryZe opened this issue Dec 17, 2019 · 2 comments
Open

Is async-std within the scope of this crate? #97

CryZe opened this issue Dec 17, 2019 · 2 comments

Comments

@CryZe
Copy link
Contributor

CryZe commented Dec 17, 2019

It seems to be possible to use hyper with async-std if you provide a Connector for it that uses async-std. Considering half the ecosystem is seemingly moving to async-std and tokio doesn't play well with async-std, there should probably be a good rustls based Connector that can be used in that case. I'm not sure if that is within the scope of hyper-rustls or if we need a second hyper-rustls-async-std.

@jbg
Copy link
Contributor

jbg commented Feb 24, 2020

It seems like it should be quite simple to implement a connector based on this one that uses async-std types instead of tokio types.

It would really just be swapping tokio's AsyncRead/AsyncWrite traits for async-std's (and dealing with any API difference) and replacing tokio-rustls with async-tls (which despite the generic name is in fact a kind of async-std-rustls).

You could enable/disable them with feature flags rather than making a separate crate, but a separate crate might be tidier especially with regard to releasing updates in sync with async-std and async-tls.

If half the ecosystem is really moving over to async-std I'm sure someone will be motivated to make the few changes needed...

@cpu
Copy link
Member

cpu commented Mar 31, 2023

Do folks still feel this is a relevant issue ~three years in? From the perspective of someone newer to the Rust ecosystem it seems like a lot of the community has converged on Tokio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants