Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto provider support #15

Closed
stevefan1999-personal opened this issue Sep 3, 2023 · 3 comments
Closed

Crypto provider support #15

stevefan1999-personal opened this issue Sep 3, 2023 · 3 comments

Comments

@stevefan1999-personal
Copy link
Contributor

Given that rustls/rustls#1405 is closer to completion, we need to think about crypto provider support.

We could still provide ring provider out of the box (I think rustls would in the end include ring as part of the default options to prevent chaos), but this would render custom crypto provider useless due to tokio-rustls usually being a transient dependency (for example axum_server usestokio-rustls) and I don't think there is a way to patch the transient dependency of axum_server without forking it.

@djc
Copy link
Member

djc commented Sep 3, 2023

Like rustls, we will make ring a feature that is enabled by default in the next semver-breaking release. axum_server will then need to do the same.

@richarddd
Copy link

rustls has now extracted crypto provider into separate dependency. Can we do the same here? 🙂

@cpu
Copy link
Member

cpu commented Dec 6, 2023

I believe this has been handled w/ 0.25:

ring is enabled by default but can be disabled. If you disable that feature and construct your Client/Server configs using the _with_provider fns you can provide your own non-default crypto provider.

@cpu cpu closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants