Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand checks on prior import to check versions #343

Closed
rustprooflabs opened this issue Jun 24, 2023 · 0 comments · Fixed by #371
Closed

Expand checks on prior import to check versions #343

rustprooflabs opened this issue Jun 24, 2023 · 0 comments · Fixed by #371
Labels
enhancement New feature or request
Milestone

Comments

@rustprooflabs
Copy link
Owner

Details

There's no protection against trying go backwards through versions, e.g. imported first with 0.9.0, then with 0.8.0. While users hopefully aren't doing that intentionally, it's not hard to imagine scenarios that could happen accidentally. (e.g. someone references older procedures)

I think adjusting the get_prior_import() function to return pgosm_flex_version in the results would make this easy enough to add a check for. The column stores values such as 0.9.0-50c6ddd. Will need to split the PgOSM Flex version from the commit hash. Right now I'm just thinking of the PgOSM Version, not the commit hash. That's not perfect, but users of --replication generally should not use the :latest Docker images, only the tagged versions.

To add the second check we'd need to internally track those official hashes and that sounds like a lot of extra maintenance overhead it'd be easy to forget or otherwise screw up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant