Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a variable goes out of scope, have the hover message say whether it's resource is dropped or not #10

Closed
vishnureddy17 opened this issue Sep 29, 2020 · 0 comments
Assignees
Labels
HATRA submission Things we should address before HATRA

Comments

@vishnureddy17
Copy link
Contributor

Currently, the hover message says "x goes out of scope". We want it to say "x goes out of scope. Its resource is dropped" or "x goes out of scope. It did not own a resource." so we can match what we said in the paper.

In the past, the hover messages always said that the resource is dropped whenever a variable of non-reference type went out of scope. This was incorrect because if ownership got moved away from a variable, there won't be a drop when that variable goes out of scope.

@vishnureddy17 vishnureddy17 transferred this issue from another repository Nov 1, 2020
@vishnureddy17 vishnureddy17 added the HATRA submission Things we should address before HATRA label Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HATRA submission Things we should address before HATRA
Projects
None yet
Development

No branches or pull requests

3 participants