gloo-net: incorrect access of global when used in a worker

[cdata]

Describe the Bug

gloo-net HTTP features cannot be used in a worker because the library always tries to access the Fetch API from Window, which will fail when running in a worker:

gloo/crates/net/src/http/mod.rs

Line 189 in 5fc0a8f

let promise = gloo_utils::window().fetch_with_request(&request);

Steps to Reproduce

1. Design a WASM-compatible program that uses gloo-net to make HTTP requests
2. Load and run it in a Web Worker

Expected Behavior

Expected HTTP requests are made.

Actual Behavior

An error, as the library attempts to access the wrong kind of global.

Additional Context

In digging around, I noticed there is some relevant history from gloo contributors: rustwasm/wasm-bindgen#2148 (comment).

Following that comment thread, I discovered that gloo previously incorporated a limited workaround for accessing global properties in a scope-agnostic way:

gloo/crates/timers/src/callback.rs

Lines 8 to 40 in 2c9e776

	thread_local! {
	static GLOBAL: WindowOrWorker = WindowOrWorker::new();
	}
	enum WindowOrWorker {
	Window(Window),
	Worker(WorkerGlobalScope),
	}
	impl WindowOrWorker {
	fn new() -> Self {
	#[wasm_bindgen]
	extern "C" {
	type Global;
	#[wasm_bindgen(method, getter, js_name = Window)]
	fn window(this: &Global) -> JsValue;
	#[wasm_bindgen(method, getter, js_name = WorkerGlobalScope)]
	fn worker(this: &Global) -> JsValue;
	}
	let global: Global = js_sys::global().unchecked_into();
	if !global.window().is_undefined() {
	Self::Window(global.unchecked_into())
	} else if !global.worker().is_undefined() {
	Self::Worker(global.unchecked_into())
	} else {
	panic!("Only supported in a browser or web worker");
	}
	}
	}

In some cases, it may feasible to take a simpler approach, such as this patch I applied to another crate that has this same issue: devashishdxt/rexie@8637e4e

[cdata]

I have created a fairly ugly patch to make gloo-net usable in DedicatedWorkerGlobalScope contexts: master...cdata:master

[allsey87]

I have created a fairly ugly patch to make gloo-net usable in DedicatedWorkerGlobalScope contexts: master...cdata:master

I wonder if a better solution would be to solve this at the wasm-bindgen level with a Global trait that is returned by js_sys::global and that covers all of the common APIs between Window and DedicatedWorkerGlobalScope. Note that there is also ServiceWorkerGlobalScope that should be considered in the design.

Alternatively we could have an enum returned from js_sys::global such as:

enum Global {
   Window(Window),
   DedicatedWorkerGlobalScope(DedicatedWorkerGlobalScope),
   ServiceWorkerGlobalScope(ServiceWorkerGlobalScope),
}

which could again cover all the common APIs between these types. Perhaps @alexcrichton has some thoughts on this?

[alexcrichton]

Given how many contexts JS can run in I don't think that's a great idea for wasm-bindgen itself, but as a helper crate somewhere I think it definitely makes sense.

[cdata]

Thanks for the attention to this issue. Perhaps a gloo-global helper crate is in order?

[allsey87]

My intuition would be to say that it belongs to gloo-util. @alexcrichton when you say that it's not a great idea for wasm-bindgen itself, are you also mean that it is not a good fit for js_sys?

[Zageron]

@cdata Thank you very much for your fork. I assume it's quite out of date now, but it still managed to resolve my issue.

[cdata]

@Zageron I don't have time to look at it right now, but if you happen to rebase the change I will happily accept a PR from you 🍻 cheers!

[flosse]

@cdata I rebased your commit and created a PR to hopefully have an upstream solution soon.