Setter has wrong name in typescript header

[dtysky]

Describe the Bug

Setter has wrong name in typescript header

Steps to Reproduce

Very simple code:

impl Color {
  #[wasm_bindgen(getter)]
  pub fn r(&self) -> f64 {
    self.0
  }

  #[wasm_bindgen(setter)]
  pub fn set_r(&mut self, r: f64) {
    self.0 = r;
    self.4 = (if (self.0 > 1.) {255.} else if (self.0 < 0.) {0.} else {self.0 * 255.}) as u8;
  }
}

wasm_bindgen will generate right javascript code:

class Color
    /**
    * @returns {number}
    */
    get r() {
        if (this.ptr === 0) {
            throw new Error('Attempt to use a moved value');
        }
        return wasm.color_r(this.ptr);
    }
    /**
    * @param {number} r
    * @returns {void}
    */
    set r(r) {
        if (this.ptr === 0) {
            throw new Error('Attempt to use a moved value');
        }
        _assertNum(r);
        return wasm.color_set_r(this.ptr, r);
    }
}

But typescript header is wrong:

class Color {
  get r(): number;
  // wrong, shoud be `set r(r: number): void`
  set set_r(r: number): void;
}

[alexcrichton]

cc @c410-f3r, would you perhaps be interested in taking a look at this?

[c410-f3r]

Ooppsss... My bad.

@alexcrichton Sure! Thanks for letting me know about this issue.

[dtysky]

Hi, @alexcrichton, @c410-f3r

There are a little difference between js file and ts header:

1. If a member only has getter in js file, it shoud be readonly in ts header:

get elements() {
return []
}

readonly elements: Array;

2. If a member has both getter and setter, it should be a normal member:

get elements() {
xxx
}

set elements(value) {
xxx
}

elements: Array;

[c410-f3r]

The new implementation made by @alexcrichton recently (awesome work) has this functionality but unfortunately it is currently inverted, i.e., a setter has readonly and a getter does not. #1577 should fix (I hope) all problems related to TS accessors.

[alexcrichton]

Thanks @c410-f3r!