Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the state of debugging? #1981

Closed
solomatov opened this issue Jan 28, 2020 · 9 comments
Closed

What is the state of debugging? #1981

solomatov opened this issue Jan 28, 2020 · 9 comments
Labels

Comments

@solomatov
Copy link

@solomatov solomatov commented Jan 28, 2020

Summary

Chrome added support for DWARF based debugging information: https://twitter.com/ChromeDevTools/status/1192803818024710145 Unfortunately, they also mentioned that wasm-bindgen doesn't support updating debug info after transformation.

So my question is:

  • How hard is it to add support for updating debug information?
  • Do you have it on your roadmap, and if so, when do you plan to implement it?
@solomatov solomatov added the question label Jan 28, 2020
@alexcrichton
Copy link
Contributor

@alexcrichton alexcrichton commented Jan 28, 2020

I commented here as well, but the gist of it is that DWARF isn't supported yet because we need to implement a DWARF transform inside of the walrus library (cc'ing @yurydelendik here as well)

@yurydelendik
Copy link

@yurydelendik yurydelendik commented Jan 28, 2020

How hard is it to add support for updating debug information?

Not trivial but possible, I started the https://github.com/yurydelendik/wtmaps-utils project to help with that.

Do you have it on your roadmap, and if so, when do you plan to implement it?

There are no specific schedule/date set for this feature.

@solomatov
Copy link
Author

@solomatov solomatov commented Jan 29, 2020

@alexcrichton @yurydelendik Thank you for the information!

@solomatov solomatov closed this Jan 29, 2020
@ortem
Copy link

@ortem ortem commented Jun 4, 2020

@alexcrichton @yurydelendik Any progress on this? AFAIU DWARF support is implemented in Binaryen WebAssembly/binaryen#2400

@NeverGivinUp NeverGivinUp mentioned this issue Aug 4, 2020
7 of 23 tasks complete
@mmgeorge
Copy link

@mmgeorge mmgeorge commented Nov 19, 2020

Also curious to know what the status of this is -- seems like this basically depends on rustwasm/walrus#67?

@alexcrichton
Copy link
Contributor

@alexcrichton alexcrichton commented Nov 20, 2020

Unfortunately there is no status update on this, it's still not implemented. This would still largely all happen in the walrus crate, but I don't think work has been done to continue on updating DWARF

@mitsuhiko
Copy link

@mitsuhiko mitsuhiko commented Nov 29, 2020

I think this issue should be reopened until resolved. I just wanted to file an issue for it. We are now about to start supporting DWARF for crash reporting and since so many projects that asked for WASM support are also using wasm-bindgen I would expect more people will ask for DWARF support.

@alexcrichton
Copy link
Contributor

@alexcrichton alexcrichton commented Nov 30, 2020

This issue is more of a question than a tracker, but @mitsuhiko would you be up to open a new issue dedicated to "support dwarf in wasm-bindgen"?

@mitsuhiko
Copy link

@mitsuhiko mitsuhiko commented Dec 3, 2020

I opened a new issue for it in #2389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants