Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-sys examples broken since 0.2.81 #2963

Closed
jhinch opened this issue Jun 24, 2022 · 3 comments
Closed

web-sys examples broken since 0.2.81 #2963

jhinch opened this issue Jun 24, 2022 · 3 comments
Labels

Comments

@jhinch
Copy link

jhinch commented Jun 24, 2022

Describe the Bug

It appears as though all of the live web-sys examples in the wasm-bindgen guide are not working and confirmed they were not working when running locally as well. Examples tested which are not working:

It seems like other live examples are still working such as the hello_world example

Steps to Reproduce

  1. Checkout main of wasm-bindgen
  2. cd examples/dom
  3. npm install
  4. npm run serve
  5. Open http://localhost:8080 in your browser
  6. See that 'Hello rust!' is never appended to the page

Expected Behavior

examples/dom is expected to append a

tag with the text hello rust!

Actual Behavior

Nothing happens

Additional Context

I ran a git bisect between 0.2.80 and the tip of main and it found 062aa5f as the first bad commit

@jhinch jhinch added the bug label Jun 24, 2022
@Liamolucko
Copy link
Collaborator

I think this was caused by #2961, so it should be fixed now.

@gengjiawen
Copy link

@Liamolucko Is there any plan to draft a new release ?

@Liamolucko
Copy link
Collaborator

@Liamolucko Is there any plan to draft a new release ?

0.2.82 was just released (in #3002)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants