Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to get rustfmt on nightly in "up and running" #72

Closed
ashleygwilliams opened this issue Apr 2, 2018 · 7 comments
Closed
Labels
good first issue Good for newcomers to-do stuff that needs to happen, so plz do it k thx

Comments

@ashleygwilliams
Copy link
Member

so- i originally put rustfmt in CI because i like enforcing style. however because this is on nightly and not yet stabilized the contributor experience is p poopy (cc @yoshuawuyts). thoughts on me ripping it out and just running it and commiting everyone once in a while? (this can make history really gross and i do love using git as a good history tool, but it might not be worth it at this point)

@ashleygwilliams ashleygwilliams added the question Further information is requested label Apr 2, 2018
@yoshuawuyts
Copy link
Contributor

yeah, still haven't fixed it yet, but haven't put in the time yet. I don't mind having development be nightly only for now. I don't mind if it stays tbh; it's def useful!

@sendilkumarn
Copy link
Member

sendilkumarn commented Apr 2, 2018

How about adding them in pre-push hooks?

And I do agree with @yoshuawuyts have it but don't worry about it atleast for now

@ashleygwilliams
Copy link
Member Author

@sendilkumarn i think it would be just as frustrating as a pre-push hook, and a lot more to set up. i'll see what other contribs think (@mgattozzi has been bit by this so much, thankful for his patience), but sounds like we're should probably just keep it?

if someone wants to add a section to the current "up and running" section of the README about how to get cargo fmt setup correctly i would welcome a PR!

@ashleygwilliams ashleygwilliams added the to-do stuff that needs to happen, so plz do it k thx label Apr 2, 2018
@ashleygwilliams ashleygwilliams changed the title rustfmt in CI- more pain than it's worth? document how to get rustfmt on nightly in "up and running" Apr 2, 2018
@mgattozzi
Copy link
Contributor

@ashleygwilliams I personally don't mind. It's just a quick fix. It'd be nice if there was some kind of pre-push hook but you can't distribute those easily as part of a repo which has always seemed like a dumb move on git's part. I'm for keeping it to enforce style. We can always make it a part of the check list when submitting a PR by creating a template that GitHub can use.

@ashleygwilliams ashleygwilliams added good first issue Good for newcomers and removed question Further information is requested labels Apr 4, 2018
@data-pup
Copy link
Member

I can try and add some documentation for this, having just run into this myself. If it is worth anything, getting rustfmt working was not hard, and I didn't find it too bad as a new contributor :)

@mgattozzi
Copy link
Contributor

Awesome! :D

@ashleygwilliams
Copy link
Member Author

closed by #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

No branches or pull requests

5 participants