Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-pack test not finding any tests in github actions #867

Closed
quodlibetor opened this issue Jun 27, 2020 · 2 comments
Closed

wasm-pack test not finding any tests in github actions #867

quodlibetor opened this issue Jun 27, 2020 · 2 comments

Comments

@quodlibetor
Copy link

quodlibetor commented Jun 27, 2020

🐛 Bug description

I'm trying to migrate chrono to github actions (travis has been slow and occasionally not running tests at all) and wasm-pack test is stating that it cannot find any tests to run, in general with output like:

Running target/wasm32-unknown-unknown/debug/deps/chrono-2353a41ba80b30bd.wasm
  no tests to run!
                                                    
       Running target/wasm32-unknown-unknown/debug/deps/wasm-f535679846a85bc5.wasm
  no tests to run!

These tests do run when I run wasm-pack locally.

Here's a minimal run that demonstrates the issue: https://github.com/chronotope/chrono/runs/814496812?check_suite_focus=true

🤔 Expected Behavior

wasm-pack test should execute my tests.

👟 Steps to reproduce

My github-actions config is in chronotope/chrono#436 , it seems straightforward, I'm happy to work to try and figure out why no tests are discovered. I've been trying to narrow it down and can't find anything. My sanity-check wasm test is in tests/wasm.rs

🌍 Your environment

github-actions runner: macos-latest and ubuntu-latest
wasm-pack version: 0.9.1
rustc version: stable - 1.44.1

@schell
Copy link

schell commented Sep 7, 2020

I was seeing this as well, and it was happening locally. It didn't seem to matter where I put my tests - they were never found. Bumping wasm_bindgen_test from 0.3.0 to 0.3.17 fixed it.

@quodlibetor
Copy link
Author

Ah, yes I forgot that I filed this: wasm-bindgen 0.2 requires wasm-bindgen-test 0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants