Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove regex completely, or add a feature for opt-out of regex #13

Closed
jondot opened this issue Dec 19, 2022 · 1 comment
Closed

remove regex completely, or add a feature for opt-out of regex #13

jondot opened this issue Dec 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jondot
Copy link
Member

jondot commented Dec 19, 2022 •
edited

On the face of it, there's nothing special regex is doing when detecting file type based on extension. It can be easily replaced with checking the end of the string, or parsing out the path using std only.

See this feedback: cargo-bins/cargo-binstall#617 (comment)
@jondot jondot added the enhancement New feature or request label Dec 19, 2022
@jondot jondot changed the title remove or add a feature for opt-out of regex remove regex completely, or add a feature for opt-out of regex Dec 19, 2022
@jondot
Copy link
Member Author

jondot commented Dec 22, 2022

actually regex is here to stay because it's offered as a feature for end users to customize.

@jondot jondot closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jondot