removed redundant features from mlua #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tealr already passes the features to mlua. No need to set them again in mlua. Some features from mlua (actually, most of them) break its API in some way that tealr needs to know about. As a result, I _highly_ recommend to not enable any features in mlua directly but instead enable their equivalent in tealr. Doing this enables them in mlua (including in the mlua you depend directly on) and makes it harder to accidentally enable a feature only in mlua, which can cause compile errors. Ideally, you don't depend on mlua directly and instead use the reexport under `tealr::mlu::mlua` to side step this entire problem but I also agree that depending on mlua directly is nicer if its used a lot and it isn't a problem for as long as you keep the feature thing in mind.
|
Hey @lenscas, thanks for this I'll merge it now best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tealr already passes the features to mlua. No need to set them again in mlua.
Some features from mlua (actually, most of them) break its API in some way that tealr needs to know about. As a result, I highly recommend to not enable any features in mlua directly but instead enable their equivalent in tealr. Doing this enables them in mlua (including in the mlua you depend directly on) and makes it harder to accidentally enable a feature only in mlua, which can cause compile errors.
Ideally, you don't depend on mlua directly and instead use the reexport under
tealr::mlu::mluato side step this entire problem but I also agree that depending on mlua directly is nicer if its used a lot and it isn't a problem for as long as you keep the feature thing in mind.