Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using git2 instead of executing git process #15

Closed
tomasol opened this issue Oct 18, 2018 · 3 comments · Fixed by #35
Closed

Consider using git2 instead of executing git process #15

tomasol opened this issue Oct 18, 2018 · 3 comments · Fixed by #35

Comments

@tomasol
Copy link

tomasol commented Oct 18, 2018

It would be nice to adapt same approach https://github.com/cstorey/git-build-version uses - reading git metadata using git2 library. This would make building in restricted environment easier, e.g. docker images for cross do not contain git binary.
@CraZySacX
Copy link
Member

Good idea. I'll get this worked in here shortly.

@tomasol
Copy link
Author

tomasol commented Oct 18, 2018

Great!
btw I hope you don't mind, for now I "borrowed" some of your code to create a pull request over there :)

@CraZySacX
Copy link
Member

Don't mind at all. Beauty of open source.

@sgkim126 sgkim126 mentioned this issue Apr 4, 2019
Closed
@teor2345 teor2345 mentioned this issue Dec 4, 2020
Merged
2 tasks
@CraZySacX CraZySacX mentioned this issue Feb 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare release 4.0.0 rustyhorde/vergen
2 participants
@tomasol @CraZySacX