Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum_depth set to a static value #86

Closed
Psycho-Pirate opened this issue Jun 2, 2023 · 0 comments · Fixed by #85
Closed

minimum_depth set to a static value #86

Psycho-Pirate opened this issue Jun 2, 2023 · 0 comments · Fixed by #85

Comments

@Psycho-Pirate
Copy link
Contributor

According to BOLT 2, for accept_message, the minimum_depth should be determined by the sender.

The sender:

    if channel_type includes option_zeroconf:
        MUST set minimum_depth to zero.
    otherwise:
        SHOULD set minimum_depth to a number of blocks it considers reasonable to avoid double-spending of the funding transaction.

Lnprototest sets it to 3. This causes tests to fail if minimum_depth required by an implementation is not equal to 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant