WavReader may be too strict on WAVEFORMATEX data

[cormac-obrien]

At least one of the WAV files used by Quake (pak0.pak/sound/doors/baseuse.wav) results in FormatError("unexpected WAVEFORMATEX size") when trying to open it. This file opens and plays successfully in mplayer, VLC and mpv.

Using hound 3.3.0:

extern crate hound;

fn main() {
    let _ = hound::WavReader::open("baseuse.wav").unwrap();
}

Output:

$ cargo run
(...)
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: \
    FormatError("unexpected WAVEFORMATEX size")', libcore/result.rs:916:5

Perhaps this should be a warning instead of a fatal error?

(This is using pak0.pak with md5sum 85fc9cee2035b66290da1e33be2ac86b)

[ruuda]

Thanks for reporting! If the struct has an unexpected size, it might have fields in there that need to be taken into account, or other fields could be at different offsets. It is possible that we can figure out the meaning, or that these fields can be safely ignored, but I would have to look at the file. Are you able to share a file to reproduce this issue? If copyright is an issue, you can truncate the file after the first 100 or so bytes of audio data. (In a hex editor, look for the string data, that is the start of the audio data chunk.) The resulting file will be corrupt, but it should be enough to understand how to read the header.

[cormac-obrien]

First 200 bytes of the file are here.

[ruuda]

Thanks! I believe the file is actually valid and Hound was being too restrictive. I pushed a fix to master, could you please confirm that you are now able to read the file?

[cormac-obrien]

Yep! This fixes the problem. Thanks for the quick update!

[ruuda]

Great, I’ll make a new release then.

[ruuda]

Hound v3.3.1 is now on crates.io.