Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: integration with EasyAdmin #115

Open
hafkenscheid opened this issue Dec 27, 2020 · 5 comments
Open

Feature: integration with EasyAdmin #115

hafkenscheid opened this issue Dec 27, 2020 · 5 comments

Comments

@hafkenscheid
Copy link

I have the idea that it might be usefull to have integration with easyadmin.

@rvanlaak
Copy link
Owner

rvanlaak commented May 8, 2021

Would be great! Any starting point on how to achieve that? Would you have time to work on a draft PR together?

@hafkenscheid
Copy link
Author

There are several possibilities, in my opinion the best being a CrudController linked to this bundle that can be integrated in an EA3 dashboard. However, several other rework needs to be done first to regain compatibility with SF5.x and PHP8. See also #114

@hafkenscheid
Copy link
Author

I have been rethinking this integration. Basically I see two options:

  1. Integration of the existing Setting-forms in the EasyAdmin template which is a simple change
  2. The CrudController as suggested above

For the second integration there are some challenges. At first, being the fact that settings don't have database entries before being saved which makes them unavailable in Crud::PAGE_INDEX views. Furthermore we need to think about the current forms having one form for all settings entries, while it might make more sense to edit op a per setting basis.

@rvanlaak
Copy link
Owner

Could you give a ballpark on how much code would be needed to add EasyAdmin support? I have no strong opinion on adding it to this bundle, but would introducing a separate bridge bundle be a more viable option?

@Chris53897
Copy link

One simple solution could be to just make a copy-paste integration.
Example:
https://github.com/Dukecity/CommandSchedulerBundle/blob/master/Resources/doc/integrations/easyadmin/ScheduledCommandCrudController.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants