Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when getting alpha or beta versions of django #10

Closed
rvanlaar opened this issue Dec 27, 2011 · 7 comments
Closed

error when getting alpha or beta versions of django #10

rvanlaar opened this issue Dec 27, 2011 · 7 comments

Comments

@rvanlaar
Copy link
Owner

The untarred_dir is incorrectly set. We need to define a filter to know exactly which folder was included in the tgz.

Have a look at the patch which also includes:

  • using offline version (don't update svn if offline)
  • logging

This may not apply cleanly as we had local changes.


Imported from Launchpad using lp2gh.

@rvanlaar
Copy link
Owner Author

(by erevilla)

@rvanlaar
Copy link
Owner Author

(by jvloothuis)
Thanks for the patch. It seems that your internal version has drifted a bit from the recent changes in trunk. I would like to incorporate the features you suggest. Could you please open separate issues for the loggin and offline support? This will help keep track of the things that are still left to do.

@rvanlaar
Copy link
Owner Author

(by erevilla)
Ok. I'll have a look if I can do it.
Regards.

El jue, 21-08-2008 a las 20:40 +0000, Jeroen Vloothuis escribió:

Thanks for the patch. It seems that your internal version has drifted a
bit from the recent changes in trunk. I would like to incorporate the
features you suggest. Could you please open separate issues for the
loggin and offline support? This will help keep track of the things that
are still left to do.

** Changed in: djangorecipe
Assignee: (unassigned) => Jeroen Vloothuis (jvloothuis)
Status: New => In Progress

@rvanlaar
Copy link
Owner Author

(by erevilla)
Here goes a small patch which resolves just the problem of alpha and beta versions of django. Basically, untarred_dir is detected during extraction of the tarball.

@rvanlaar
Copy link
Owner Author

(by jvloothuis)
A (slightly different) fix has been committed to the trunk. Thanks for the report and the patch.

@rvanlaar
Copy link
Owner Author

(by erevilla)
Ok. I've had a look.

It seems that the line:

untarred_dir = os.path.join(extraction_dir,
os.listdir(extraction_dir)[0])

would work well if you use just the first time, i.e.
if you'd install first the 1.0-alpha_1 version, and then 1.0-beta_1,
both versions would be in django_archive directory, but would still use
the 1.0-alpha version no the beta.

Regards.
Erny

El sáb, 30-08-2008 a las 15:18 +0000, Jeroen Vloothuis escribió:

A (slightly different) fix has been committed to the trunk. Thanks for
the report and the patch.

** Changed in: djangorecipe
Status: In Progress => Fix Committed

** Changed in: djangorecipe
Status: Fix Committed => Fix Released

@rvanlaar
Copy link
Owner Author

(by jvloothuis)
Have you actually encountered the error? I am asking since the recipe always removes (or should remove) the django_archive directory after installation. This means that it we should be able to expect it to be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant