Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC paths #76

Closed
italobusi opened this issue Jun 3, 2020 · 1 comment · Fixed by #81
Closed

RPC paths #76

italobusi opened this issue Jun 3, 2020 · 1 comment · Fixed by #81
Milestone

Comments

@italobusi
Copy link
Collaborator

The are some issues with RPC XPaths

The following code is accepted by pyang 1.75 but not by pyang 2.1:

                type leafref {
                  path "/te:tunnels-path-compute/te:input/"
                     + "te:path-compute-info/"
                     + "te-pc:tunnel-attributes/te-pc:tunnel-name";
                }

The following code instead is accepted by pyang 2.1 but not by pyang 1.7.5:

              leaf tunnel-attributes-ref {
                type leafref {
                  path "/te:tunnels-path-compute/"
                     + "te:path-compute-info/"
                     + "te-pc:tunnel-attributes/te-pc:tunnel-name";
                }

Moreover the following when statement, which is quite useful to constraint which information is provided by the RPC output based on some attributes in the RPC input, is accepted by pyang 1.7.5 but not accepted by pyang 2.1;

  augment "/te:tunnels-actions/te:output" {
    description
      "Augment Tunnels Action RPC input with path delete result";
    
    container path-computed-delete-result {
      when "derived-from-or-self(../../te:input/te:action-info/"
         + "te:action, 'tunnel-action-path-compute-delete')";
      description "Path Delete RPC output";
      leaf-list path-compute-transaction-id {
        type string;
        description
          "The list of the transaction-id values of the
           transient states that have been successfully deleted";
      }
    }   // container path-computed-delete-result
  }   // path-delete rpc output

@italobusi italobusi added this to the wg-lc milestone Jun 3, 2020
@italobusi
Copy link
Collaborator Author

italobusi commented Aug 4, 2020

As discussed during the TEAS WG session in IETF 108, this issue has been raised on pyang github: mbj4668/pyang#662

italobusi added a commit that referenced this issue Aug 7, 2020
@italobusi italobusi linked a pull request Oct 1, 2020 that will close this issue
italobusi added a commit that referenced this issue Oct 1, 2020
Fixing issue #76, as suggested in:
- mbj4668/pyang#662 (comment)
- https://mailarchive.ietf.org/arch/msg/netmod/3vmzza2QQ2ZVxUOU_daRTZDt0P8/

Co-authored-by: sergiobelotti <sergio.belotti@nokia.com>
italobusi added a commit that referenced this issue Feb 8, 2021
* Update ietf-te-path-computation.yang

Fixing issue #76 as suggested in mbj4668/pyang#662 (comment)

Updated based on the feedbacks from Martin Björklund:
https://mailarchive.ietf.org/arch/msg/netmod/3vmzza2QQ2ZVxUOU_daRTZDt0P8/

Updated to address YD review comments (open issue #83 )

Updated YANG model:
- to address Tom Petch's comments (#82)
- to clean-up the use of groupings (#84 (comment))

Updated as proposed in #77 (comment)

Update to address review comment: #84 (comment)

Co-authored-by: sergiobelotti <sergio.belotti@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant