Check for trouble-prone config in "gemrc"s, fix #855 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
mpapis
added a commit
that referenced
this pull request
Sep 25, 2012
…em-config Check for trouble-prone config in "gemrc"s, fix #855
|
Great work! Thank you Mathieu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a first try to fix #855.
Since I'm don't know the implementation details of the installation/update process, I prefer to do the check each time RVM is loaded.
Since this could be tiring of people very quickly, I added an RVM configuration:
export rvm_ignore_gemrc_issues=1to cancel the check.I didn't relied on the output of
gem envbecause it doesn't seem to take into account the sub-command configurations (such asgem_install: [...].