Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rvm-test inside the rvm repository #4663

Closed
eregon opened this issue Apr 11, 2019 · 5 comments
Closed

Merge rvm-test inside the rvm repository #4663

eregon opened this issue Apr 11, 2019 · 5 comments
Milestone

Comments

@eregon
Copy link
Contributor

eregon commented Apr 11, 2019

Description

Currently, the RVM test suite is a separate repository: https://github.com/rvm/rvm-test

It is imported as a git submodule.
Git submodule are to say the least inconvenient to work with.

As such, I proposed to merge rvm-test in rvm, since I don't think it's very valuable to have its own repository, and it's quite inconvenient to fix a bug and add a test:
3 PRs (rvm, rvm-test, bump import in rvm) to 2 different repos instead of just one PR to one repo.

cc @pkuczynski @mpapis

@eregon
Copy link
Contributor Author

eregon commented Apr 11, 2019

Also, the CI of rvm-test is redundant with rvm's, and not in sync, so it's not possible to introduce a new test without the fix being merged in rvm first, and there are probably more synchronization issues.

@eregon
Copy link
Contributor Author

eregon commented Apr 11, 2019

e.g., the CI of rvm-test is broken on rvm/rvm-test#27, but it doesn't matter since the important one is rvm's CI.

@pkuczynski
Copy link
Member

I agree. I think the only reason why those are not included is to make the bundle smaller, but the hassle is not worth it I think. @mpapis?

@eregon
Copy link
Contributor Author

eregon commented Apr 26, 2019

@mpapis gentle ping 😃

@eregon
Copy link
Contributor Author

eregon commented Aug 24, 2019

This was done in 7930978 / #4757 as a git subtree, thanks @mpapis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants