Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the neighbourhood size In PathCore implementations? #22

Closed
mjack3 opened this issue Jan 13, 2022 · 5 comments
Closed

What's the neighbourhood size In PathCore implementations? #22

mjack3 opened this issue Jan 13, 2022 · 5 comments

Comments

@mjack3
Copy link

mjack3 commented Jan 13, 2022

Hello and thank for your contribution. Really good job

Trying your code i am wondering if this attribute n_reweight is the neighbourhood size described in the Paper.

@rvorias
Copy link
Owner

rvorias commented Jan 13, 2022

Hi,

No, the neighbourhood size is defined at

self.average = torch.nn.AvgPool2d(3, stride=1)

We use the averaging to combined information of neighbouring patches. In this case the neighbourhood kernel is of size 3.

@mjack3
Copy link
Author

mjack3 commented Jan 13, 2022

Hello, thanks for your answer. I did a mistake in my question, I would like to where is defined the value of "b nearest patch-features"

@rvorias
Copy link
Owner

rvorias commented Jan 13, 2022

Yes, n_reweight = b in the paper.

@mjack3
Copy link
Author

mjack3 commented Jan 13, 2022

Thanks! to close this issue, I would appreciate to do a last question. In README section I see this about PatchCore

* actually does not have any knn mechanism, but shares many things implementation-wise.

is KNN implemented? If not, maybe I could make a develop

@rvorias rvorias closed this as completed Jan 13, 2022
@rvorias
Copy link
Owner

rvorias commented Jan 13, 2022

That is actually a note on Padim, not PatchCore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants