Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] should support automatically folding when location.pathname changes #4

Closed
Rvtea opened this issue May 29, 2018 · 2 comments
Closed

[feat] should support automatically folding when location.pathname changes #4

Rvtea opened this issue May 29, 2018 · 2 comments
Assignees
@Rvtea
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Rvtea
Copy link
Owner

Rvtea commented May 29, 2018

as gitlab is becoming a SPA while when we go to the MR page, it does not go to xxx/diffs part at first, so if the user change to diffs tab, the script should work for once (ONLY once as first entry, as the user might want to check folded files when reviewing code)
@Rvtea
Copy link
Owner Author

Rvtea commented May 29, 2018

Currently user can go to diffs tab and open this extension to click the Click to Fold button as workaround, but we want this to be automatically.

@Rvtea Rvtea self-assigned this May 29, 2018
@Rvtea Rvtea added enhancement New feature or request good first issue Good for newcomers labels May 29, 2018
@Rvtea
Copy link
Owner Author

Rvtea commented May 29, 2018

Glad to found that this has been supported in v1.1 upon the DOMContentLoaded event triggered. Close this.

@Rvtea Rvtea closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rvtea Rvtea

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rvtea