Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea: RGB LED color correction #811

Closed
mize opened this issue May 30, 2015 · 2 comments
Closed

Feature idea: RGB LED color correction #811

mize opened this issue May 30, 2015 · 2 comments

Comments

@mize
Copy link

mize commented May 30, 2015

Caveat: I'm extremely new to hardware.

Tinkering with an RGB LED, I noticed I got mixed colors that were different from what I expected based on hex values passed via the color method. So I read some background info on color variations:

Looks like the FastLED lib has some constant white point values that they allow the user to designate via setCorrection or setTemperature methods, and the resulting value transforms any further colors passed in.

Could be cool to add this feature to J5, in Led.RGB constructor options and as an instance method for flexibility during runtime. I think it would be handy to use a standard set of values, as well as letting J5 user designate a custom white point as a hex string.

I'm willing to give it a go. Would other folks find this useful? I'll also look around to see whether this is a solved problem via some other JS lib.

@rwaldron
Copy link
Owner

rwaldron commented Nov 5, 2015

Any updates?

@dtex
Copy link
Collaborator

dtex commented Jan 16, 2018

Hi @mize

I'm going to close this since we haven't heard back, but it still sounds like a good addition. To make sure it doesn't get forgotten I've added it to the Johnny-Five Requested Features page.

@dtex dtex closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants