Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URLRequest & URL #67

Closed
BrunoMiguens opened this issue Oct 20, 2022 · 1 comment
Closed

Allow URLRequest & URL #67

BrunoMiguens opened this issue Oct 20, 2022 · 1 comment
Assignees

Comments

@BrunoMiguens
Copy link

Is your feature request related to a problem? Please describe.
Currently, we have no way to perform health checks besides using a standard GET request or fetching a file. This is fine for most cases. In my case, we're using GraphQL, forcing us to use a POST to perform a health check query. If we try to fetch it using a GET, we'll report errors on the server side which we're trying to avoid.

Also, there's no easy way to add headers which may be required if the endpoint or file has some validation or protection.

The issue is also opened on the Hyperconnectivity repo - rwbutler/Hyperconnectivity#10 - it seems the repo is not actively maintained.

Describe the solution you'd like
As commented in the Hyperconnectivity repo (with an MR opened), we could use either an URL or URLRequest. This way, we don't need to make any drastic changes and still open the door to many more useful features and customisation when pinging or polling some servers to check internet connectivity.

Describe alternatives you've considered
We could create different functions or use an enum with some extensions to simplify the implementation. The last option will introduce breaking changes when updating; however, they are very isolated.

Additional context
N/A

@rwbutler rwbutler self-assigned this Sep 12, 2023
@rwbutler
Copy link
Owner

@BrunoMiguens This should be resolved in 6.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants