Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] New modpack installer does not account for desired SMAPI version #69

Closed
RyanWalpole opened this issue Jul 5, 2022 · 0 comments
Closed

[Issue] New modpack installer does not account for desired SMAPI version #69

RyanWalpole opened this issue Jul 5, 2022 · 0 comments
Assignees
@RyanWalpole
Labels
status: needs triage Requires assessment to determine severity, impact and to collect more data on the issue. type: implementation A feature or bug that will be worked on and implemented.
Projects
Stardew Valley Mod Manager (Stable)
Milestone
v220802_Stable

Comments

@RyanWalpole
Copy link
Collaborator

Describe the Issue
The new modpack installer does not know which SMAPI version the modpack is designed for. This was a key feature of the old one. Look into adding this somehow.
@RyanWalpole RyanWalpole added status: needs triage Requires assessment to determine severity, impact and to collect more data on the issue. type: implementation A feature or bug that will be worked on and implemented. labels Jul 5, 2022
@RyanWalpole RyanWalpole added this to the v220701_stable milestone Jul 5, 2022
@RyanWalpole RyanWalpole self-assigned this Jul 5, 2022
@RyanWalpole RyanWalpole moved this from To do to In Development in Stardew Valley Mod Manager (Stable) Jul 8, 2022
@RyanWalpole RyanWalpole moved this from In Development to To do in Stardew Valley Mod Manager (Stable) Jul 8, 2022
RWELabs added a commit that referenced this issue Aug 16, 2022
@RWELabs @RyanWalpole
Update SDVMP Generator (Code)
3f49a27 
Create new "SMAPI Target" field for generating a modpack, for use in #69 implementation.
Also addresses #99 by implementing the disabling of buttons when operations are in place.

Co-Authored-By: Ryan Walpole <69621127+RyanWalpole@users.noreply.github.com>
RWELabs added a commit that referenced this issue Aug 16, 2022
@RWELabs @RyanWalpole
Update SDVMP Generator (UI)
78fea68 
Add new SMAPI Target UI textbox for implementing #69

Co-Authored-By: Ryan Walpole <69621127+RyanWalpole@users.noreply.github.com>
RWELabs added a commit that referenced this issue Aug 17, 2022
@RWELabs @RyanWalpole
Update SDVMP Generator (Code)
5bbfbe4 
Fixed up an issue with the SMAPI target version not saving the text from the textbox, rather the textbox itself. For implementation of #69

Co-Authored-By: Ryan Walpole <69621127+RyanWalpole@users.noreply.github.com>
RWELabs added a commit that referenced this issue Aug 17, 2022
@RWELabs @RyanWalpole
Update SDVMPGen
8057dd6 
Update SDVMPGen to v220801 with the following changes:
- Implemented fix for #99
- Implemented SMAPI target version number for #69

Co-Authored-By: Ryan Walpole <69621127+RyanWalpole@users.noreply.github.com>
@RyanWalpole RyanWalpole moved this from To do to In Development in Stardew Valley Mod Manager (Stable) Aug 17, 2022
RWELabs added a commit that referenced this issue Aug 18, 2022
@RWELabs @RyanWalpole
Update MPInstaller (Issue #69 )
0833ecd 
Implement #69 - MPInstaller now detects the SMAPI target version (if defined) from the SDVMP file.

Co-Authored-By: Ryan Walpole <69621127+RyanWalpole@users.noreply.github.com>
RWELabs added a commit that referenced this issue Aug 18, 2022
@RWELabs @RyanWalpole
Update MPInstaller (UI - Issue #69 )
dd20f9a 
Update UI for MPInstaller to implement #69 - the window will now display the current and targeted SMAPI version.

Co-Authored-By: Ryan Walpole <69621127+RyanWalpole@users.noreply.github.com>
@RyanWalpole RyanWalpole moved this from In Development to In Testing in Stardew Valley Mod Manager (Stable) Aug 18, 2022
@RyanWalpole RyanWalpole mentioned this issue Aug 23, 2022
Merged
@RyanWalpole RyanWalpole moved this from In Testing to Fixed In Release in Stardew Valley Mod Manager (Stable) Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanWalpole RyanWalpole

Labels
status: needs triage Requires assessment to determine severity, impact and to collect more data on the issue. type: implementation A feature or bug that will be worked on and implemented.
Projects
Stardew Valley Mod Manager (Stable)
Fixed In Release
Milestone
v220802_Stable
Development

No branches or pull requests
1 participant
@RyanWalpole