forked from openjdk/skara
/
ReviewArchive.java
409 lines (354 loc) · 17.5 KB
/
ReviewArchive.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
package org.openjdk.skara.bots.mlbridge;
import org.openjdk.skara.census.Contributor;
import org.openjdk.skara.email.*;
import org.openjdk.skara.forge.*;
import org.openjdk.skara.host.*;
import org.openjdk.skara.issuetracker.Comment;
import org.openjdk.skara.vcs.Hash;
import java.net.URI;
import java.nio.charset.StandardCharsets;
import java.security.*;
import java.util.*;
import java.util.stream.*;
class ReviewArchive {
private final PullRequestInstance prInstance;
private final CensusInstance censusInstance;
private final EmailAddress sender;
private final List<Email> existing;
private final Map<String, Email> existingIds = new HashMap<>();
private final List<Email> generated = new ArrayList<>();
private final Map<String, Email> generatedIds = new HashMap<>();
private final Set<EmailAddress> approvalIds = new HashSet<>();
private final List<Hash> reportedHeads;
private final List<Hash> reportedBases;
private EmailAddress getAuthorAddress(HostUser originalAuthor) {
var contributor = censusInstance.namespace().get(originalAuthor.id());
if (contributor == null) {
return EmailAddress.from(originalAuthor.fullName(),
censusInstance.namespace().name() + "+" +
originalAuthor.id() + "+" + originalAuthor.userName() + "@" +
censusInstance.configuration().census().domain());
} else {
return EmailAddress.from(contributor.fullName().orElse(originalAuthor.fullName()),
contributor.username() + "@" + censusInstance.configuration().census().domain());
}
}
private EmailAddress getUniqueMessageId(String identifier) {
try {
var prSpecific = prInstance.pr().repository().name().replace("/", ".") + "." + prInstance.id();
var digest = MessageDigest.getInstance("SHA-256");
digest.update(prSpecific.getBytes(StandardCharsets.UTF_8));
digest.update(identifier.getBytes(StandardCharsets.UTF_8));
var encodedCommon = Base64.getUrlEncoder().encodeToString(digest.digest());
return EmailAddress.from(encodedCommon + "." + UUID.randomUUID() + "@" + prInstance.pr().repository().url().getHost());
} catch (NoSuchAlgorithmException e) {
throw new RuntimeException("Cannot find SHA-256");
}
}
private EmailAddress getMessageId() {
return getUniqueMessageId("fc");
}
private EmailAddress getMessageId(Comment comment) {
return getUniqueMessageId("pc" + comment.id());
}
private EmailAddress getMessageId(ReviewComment comment) {
return getUniqueMessageId("rc" + comment.id());
}
private EmailAddress getMessageId(Hash hash) {
return getUniqueMessageId("ha" + hash.hex());
}
private EmailAddress getMessageId(Review review) {
return getUniqueMessageId("rv" + review.id());
}
private String getStableMessageId(EmailAddress uniqueMessageId) {
return uniqueMessageId.localPart().split("\\.")[0];
}
private Set<String> getStableMessageIds(Email email) {
var ret = new HashSet<String>();
ret.add(getStableMessageId(email.id()));
if (email.hasHeader("PR-Collapsed-IDs")) {
var additional = email.headerValue("PR-Collapsed-IDs").split(" ");
ret.addAll(Arrays.asList(additional));
}
return ret;
}
private Email topEmail() {
if (!existing.isEmpty()) {
return existing.get(0);
}
return generated.get(0);
}
// Returns a suitable parent to use for a general comment
private Email latestGeneralComment() {
return Stream.concat(existing.stream(), generated.stream())
.filter(email -> !email.hasHeader("PR-Head-Hash"))
.filter(email -> email.subject().startsWith("Re: RFR"))
.max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence"))))
.orElse(topEmail());
}
// Returns the top-level comment for a certain head hash
private Email topCommentForHash(Hash hash) {
return Stream.concat(existing.stream(), generated.stream())
.filter(email -> email.hasHeader("PR-Head-Hash"))
.filter(email -> email.headerValue("PR-Head-Hash").equals(hash.hex()))
.findFirst()
.orElse(topEmail());
}
private Email parentForReviewComment(ReviewComment reviewComment) {
var parent = topCommentForHash(reviewComment.hash());
if (reviewComment.parent().isPresent()) {
var parentId = getStableMessageId(getMessageId(reviewComment.parent().get()));
var last = Stream.concat(existing.stream(), generated.stream())
.filter(email -> (email.hasHeader("References") && email.headerValue("References").contains(parentId)) ||
(getStableMessageId(email.id()).equals(parentId)) ||
(email.hasHeader("PR-Collapsed-IDs") && email.headerValue("PR-Collapsed-IDs").contains(parentId)))
.max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence"))));
if (last.isEmpty()) {
throw new RuntimeException("Failed to find parent");
} else {
return last.get();
}
}
return parent;
}
ReviewArchive(EmailAddress sender, PullRequestInstance prInstance, CensusInstance censusInstance, List<Email> sentMails) {
this.sender = sender;
this.prInstance = prInstance;
this.censusInstance = censusInstance;
existing = sentMails;
for (var email : existing) {
var stableIds = getStableMessageIds(email);
for (var stableId : stableIds) {
existingIds.put(stableId, email);
}
}
// Determine the latest hashes reported
reportedHeads = existing.stream()
.filter(email -> email.hasHeader("PR-Head-Hash"))
.map(email -> email.headerValue("PR-Head-Hash"))
.map(Hash::new)
.collect(Collectors.toList());
reportedBases = existing.stream()
.filter(email -> email.hasHeader("PR-Base-Hash"))
.map(email -> email.headerValue("PR-Base-Hash"))
.map(Hash::new)
.collect(Collectors.toList());
}
Hash latestHead() {
if (reportedHeads.isEmpty()) {
throw new IllegalArgumentException("No head reported yet");
}
return reportedHeads.get(reportedHeads.size() - 1);
}
Hash latestBase() {
if (reportedBases.isEmpty()) {
throw new IllegalArgumentException("No base reported yet");
}
return reportedBases.get(reportedBases.size() - 1);
}
int revisionCount() {
return reportedHeads.size();
}
void create(URI webrev) {
var body = ArchiveMessages.composeConversation(prInstance, webrev);
var id = getMessageId();
var email = Email.create("RFR: " + prInstance.pr().title(), body)
.sender(sender)
.author(getAuthorAddress(prInstance.pr().author()))
.id(id)
.header("PR-Head-Hash", prInstance.headHash().hex())
.header("PR-Base-Hash", prInstance.baseHash().hex())
.build();
generated.add(email);
generatedIds.put(getStableMessageId(id), email);
}
private String latestHeadPrefix() {
return String.format("[Rev %02d]", revisionCount());
}
void addFull(URI webrev) {
var body = ArchiveMessages.composeRebaseComment(prInstance, webrev);
var id = getMessageId(prInstance.headHash());
var parent = topEmail();
var email = Email.reply(parent, "Re: " + latestHeadPrefix() + " RFR: " + prInstance.pr().title(), body)
.sender(sender)
.author(getAuthorAddress(prInstance.pr().author()))
.recipient(parent.author())
.id(id)
.header("PR-Head-Hash", prInstance.headHash().hex())
.header("PR-Base-Hash", prInstance.baseHash().hex())
.header("PR-Sequence", Integer.toString(existing.size() + generated.size()))
.build();
generated.add(email);
generatedIds.put(getStableMessageId(id), email);
}
void addIncremental(URI fullWebrev, URI incrementalWebrev) {
var body = ArchiveMessages.composeIncrementalComment(latestHead(), prInstance, fullWebrev, incrementalWebrev);
var id = getMessageId(prInstance.headHash());
var parent = topEmail();
var email = Email.reply(parent, "Re: " + latestHeadPrefix() + " RFR: " + prInstance.pr().title(), body)
.sender(sender)
.author(getAuthorAddress(prInstance.pr().author()))
.recipient(parent.author())
.id(id)
.header("PR-Head-Hash", prInstance.headHash().hex())
.header("PR-Base-Hash", prInstance.baseHash().hex())
.header("PR-Sequence", Integer.toString(existing.size() + generated.size()))
.build();
generated.add(email);
generatedIds.put(getStableMessageId(id), email);
}
private Optional<Email> findCollapsable(Email parent, HostUser author, String subject) {
var parentId = getStableMessageId(parent.id());
// Is it a self-reply?
if (parent.author().equals(getAuthorAddress(author)) && generatedIds.containsKey(parentId)) {
// But avoid extending top-level parents
if (!parent.hasHeader("PR-Head-Hash")) {
// And only collapse identical subjects
if (parent.subject().equals(subject)) {
return Optional.of(parent);
}
}
}
// Have we already replied to the same parent?
for (var candidate : generated) {
if (!candidate.hasHeader("In-Reply-To")) {
continue;
}
var inReplyTo = EmailAddress.parse(candidate.headerValue("In-Reply-To"));
var candidateParentId = getStableMessageId(inReplyTo);
if (candidateParentId.equals(parentId) && candidate.author().equals(getAuthorAddress(author))) {
// Only collapse identical subjects
if (candidate.subject().equals(subject)) {
return Optional.of(candidate);
}
}
}
return Optional.empty();
}
private void addReplyCommon(Email parent, HostUser author, String subject, String body, EmailAddress id) {
if (!subject.startsWith("Re: ")) {
subject = "Re: " + subject;
}
// Collapse self-replies and replies-to-same that have been created in this run
var collapsable = findCollapsable(parent, author, subject);
if (collapsable.isPresent()) {
// Drop the parent
var parentEmail = collapsable.get();
generated.remove(parentEmail);
generatedIds.remove(getStableMessageId(parentEmail.id()));
var collapsed = parentEmail.hasHeader("PR-Collapsed-IDs") ? parentEmail.headerValue("PR-Collapsed-IDs") + " " : "";
collapsed += getStableMessageId(parentEmail.id());
var reply = ArchiveMessages.composeCombinedReply(parentEmail, body, prInstance);
var email = Email.from(parentEmail)
.body(reply)
.subject(subject)
.id(id)
.header("PR-Collapsed-IDs", collapsed)
.header("PR-Sequence", Integer.toString(existing.size() + generated.size()))
.build();
generated.add(email);
generatedIds.put(getStableMessageId(id), email);
} else {
var reply = ArchiveMessages.composeReply(parent, body, prInstance);
var email = Email.reply(parent, subject, reply)
.sender(sender)
.author(getAuthorAddress(author))
.recipient(parent.author())
.id(id)
.header("PR-Sequence", Integer.toString(existing.size() + generated.size()))
.build();
generated.add(email);
generatedIds.put(getStableMessageId(id), email);
}
}
void addComment(Comment comment) {
var id = getMessageId(comment);
if (existingIds.containsKey(getStableMessageId(id))) {
return;
}
var parent = latestGeneralComment();
addReplyCommon(parent, comment.author(), "Re: RFR: " + prInstance.pr().title(), comment.body(), id);
}
private String projectRole(Contributor contributor) {
var version = censusInstance.configuration().census().version();
if (censusInstance.project().isLead(contributor.username(), version)) {
return "Lead";
} else if (censusInstance.project().isReviewer(contributor.username(), version)) {
return "Reviewer";
} else if (censusInstance.project().isCommitter(contributor.username(), version)) {
return "Committer";
} else if (censusInstance.project().isAuthor(contributor.username(), version)) {
return "Author";
}
return "no project role";
}
void addReview(Review review) {
var id = getMessageId(review);
if (existingIds.containsKey(getStableMessageId(id))) {
return;
}
// Default parent and subject
var parent = topCommentForHash(review.hash());
var subject = parent.subject();
var replyBody = ArchiveMessages.reviewCommentBody(review.body().orElse(""));
addReplyCommon(parent, review.reviewer(), subject, replyBody, id);
}
void addReviewVerdict(Review review) {
var id = getMessageId(review);
if (existingIds.containsKey(getStableMessageId(id))) {
return;
}
var contributor = censusInstance.namespace().get(review.reviewer().id());
var isReviewer = contributor != null && censusInstance.project().isReviewer(contributor.username(), censusInstance.configuration().census().version());
// Default parent and subject
var parent = topCommentForHash(review.hash());
var subject = parent.subject();
// Approvals by Reviewers get special treatment - post these as top-level comments
if (review.verdict() == Review.Verdict.APPROVED && isReviewer) {
approvalIds.add(id);
}
var userName = contributor != null ? contributor.username() : review.reviewer().userName() + "@" + censusInstance.namespace().name();
var userRole = contributor != null ? projectRole(contributor) : "no OpenJDK username";
var replyBody = ArchiveMessages.reviewVerdictBody(review.body().orElse(""), review.verdict(), userName, userRole);
addReplyCommon(parent, review.reviewer(), subject, replyBody, id);
}
void addReviewComment(ReviewComment reviewComment) {
var id = getMessageId(reviewComment);
if (existingIds.containsKey(getStableMessageId(id))) {
return;
}
var parent = parentForReviewComment(reviewComment);
var body = new StringBuilder();
// Add some context to the first post
if (reviewComment.parent().isEmpty()) {
body.append(reviewComment.path()).append(" line ").append(reviewComment.line()).append(":\n\n");
try {
var contents = prInstance.pr().repository().fileContents(reviewComment.path(), reviewComment.hash().hex()).lines().collect(Collectors.toList());
for (int i = Math.max(0, reviewComment.line() - 2); i < Math.min(contents.size(), reviewComment.line() + 1); ++i) {
body.append("> ").append(i + 1).append(": ").append(contents.get(i)).append("\n");
}
body.append("\n");
} catch (RuntimeException e) {
body.append("> (failed to retrieve contents of file, check the PR for context)\n");
}
}
body.append(reviewComment.body());
addReplyCommon(parent, reviewComment.author(), parent.subject(), body.toString(), id);
}
List<Email> generatedEmails() {
var finalEmails = new ArrayList<Email>();
for (var email : generated) {
for (var approvalId : approvalIds) {
var collapsed = email.hasHeader("PR-Collapsed-IDs") ? email.headerValue("PR-Collapsed-IDs") + " " : "";
if (email.id().equals(approvalId) || collapsed.contains(getStableMessageId(approvalId))) {
email = Email.reparent(topEmail(), email)
.subject("Re: [Approved] " + "RFR: " + prInstance.pr().title())
.build();
break;
}
}
finalEmails.add(email);
}
return finalEmails;
}
}