Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange Results in The Benchmarker #1038

Closed
AshtonKem opened this issue Jun 24, 2019 · 3 comments
Closed

Strange Results in The Benchmarker #1038

AshtonKem opened this issue Jun 24, 2019 · 3 comments

Comments

@AshtonKem
Copy link

The Rocket results for The Benchmarker Web Framework Tests show some results that seem to indicate some sort occasional performance problem. In particular the response time showed some very high 99th and 99.9th percentile latencies.

Results:
50th Percentile: 3.12ms
90th Percentile: 6.06ms
99th Percentile: 2247.48ms
99.9th Percentile: 6594.82ms

While Rocket isn't the only framework in this test to take multiple seconds to respond, it is the only Rust framework to exhibit this behavior. Given the extremely simple nature of the code under test, I suspect that there might be some latent but rare performance problem dogging Rocket.

It looks like the tests were updated yesterday with Rocket 0.4.1.

@jebrosen
Copy link
Collaborator

My guess is some known issues with performance and keep-alive in hyper 0.10 / rocket 0.4 - the benchmarking tool is likely running into these and it skews the results, both fairly and unfairly. I stand by my last comment on #1023:

From where I stand, trying to improve performance on hyper 0.10 (which is barely maintained) is not worth the effort compared to moving to and improving hyper 0.12. As such, I'm going to close this issue. #17 and #1008 are good places to watch for further progress.

@SergioBenitez
Copy link
Member

Yeah, this is almost certainly a keep_alive issue. It would be useful to try re-running the benchmark with keep_alive = 0.

@jebrosen
Copy link
Collaborator

Closing due to inactivity and #1023 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants