Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting users and re-subscribing #15

Closed
mariusherea opened this issue Mar 26, 2021 · 7 comments · Fixed by #26
Closed

Deleting users and re-subscribing #15

mariusherea opened this issue Mar 26, 2021 · 7 comments · Fixed by #26
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@mariusherea
Copy link

If I delete all the users from Perfectly Push > Users, it should delete all of them and users should be asked to allow notifications on their next visit, right? But is not happening. Deleting all users only deletes them from the admin interface. When visiting the website (cache cleared), deleted users are not prompted to allow notifications and if you click on the bottom bell icon, the checkbox is already checked. Unchecking that box returns an error "Could not change the preference, try again" (btw, the plugin should allow us to change this text from the settings because not everybody speaks English).

@rwngallego
Copy link
Collaborator

Hello @mariusherea thank you for your feedback. Honestly that scenario hasn't been considered yet. In order to understand how to implement it better, why do you delete them in the first place? Do you want to block any of them or just want to start over again with the user subscriptions?

One side note, keep in mind that we cannot alter the Browser permissions that the user gave to the site. It means that even if we removed the users from the system, they are still allowing us to send them notifications. Internally we can opt them out from the site (unmark the subscription checkbox from the bell), however I doubt it's a good idea to show them again the subscription dialog as they're already giving us permissions. What do you think?

Finally, in regards to the message text, sure, we will make it customizable. Thank you very much!

@rwngallego rwngallego added bug Something isn't working enhancement New feature or request labels Mar 26, 2021
@mariusherea
Copy link
Author

Initially plugin was not working (Nginx). It was appearing as sending the notifications successfully but users were not receiving anything.
Then you released an update. Now the plugin was failing to send the notifications. I deleted the users trying to force it to ask for permission again. Wanted to re-subscribe. And couldn't. Hance the problem.

@rwngallego
Copy link
Collaborator

Ok, thank you for letting us know. The workaround for the users you deleted is to change the Service Worker scope (Perfecty Push > Settings > Service Worker Scope) to something different to what you have (use / or /perfecty/push or any other relative path). That will force the service workers to re-register and the users will subscribe again automatically (and create the users in the DB).

@rwngallego
Copy link
Collaborator

By the way, are you using https? Remember Push Notifications only work on secure sites.

@mariusherea
Copy link
Author

Yes, https always. Workaround fixed the error appearing when the user tries to uncheck the checkbox on the front end.

@rwngallego
Copy link
Collaborator

Great, I see that your problem was solved by giving the notification permissions to your browser in MacOS. We will fix the bug for the re-subscription checks and make the text customizable. Thank you!

@rwngallego rwngallego added this to To do in Work items Mar 28, 2021
@rwngallego rwngallego moved this from To do to In progress in Work items Apr 6, 2021
@rwngallego rwngallego linked a pull request Apr 12, 2021 that will close this issue
@rwngallego
Copy link
Collaborator

This has been fixed in v1.1.1

@rwngallego rwngallego moved this from In progress to Done in Work items Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants