Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linting #125

Closed
rwnx opened this issue Mar 20, 2023 · 1 comment · Fixed by #126
Closed

Fix Linting #125

rwnx opened this issue Mar 20, 2023 · 1 comment · Fixed by #126

Comments

@rwnx
Copy link
Owner

rwnx commented Mar 20, 2023

  • This PR failed autoblack because of files that aren't even changed in the commit
    • Could this be because of a version change to black? If so i think we should pin/lock black's version (pipenv?)

minimum technical solution: run black and commit the changes :)

@rwnx
Copy link
Owner Author

rwnx commented Mar 29, 2023

  1. i couldn't replicate this locally. so maybe it was a python version thing? (old action was running on 3.8.

  2. i've pinned the python version and the black version in the workflow for 1.25.0.

I will re-open this issue if we see it again.

@rwnx rwnx mentioned this issue Mar 29, 2023
@rwnx rwnx closed this as completed in #126 Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant