Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Requirements in GMM Trainings #354

Open
Atticus1806 opened this issue Feb 8, 2023 · 2 comments
Open

Extra Requirements in GMM Trainings #354

Atticus1806 opened this issue Feb 8, 2023 · 2 comments

Comments

@Atticus1806
Copy link
Contributor

After looking at some crashed jobs I found some lets say unusual values for requirements like GB in my GMM jobs (10, 7, 5).
Short investigation found that the parameters "*_extra_rqmt" do not replace the requirement, but rather add the requirements to the basic rqmt (c.f. udpate_rqmt in mm_sequence.py).
After talking to @JackTemaki we conlcuded that this is somewhat surprising and usually done differently, where handin rqmt to a job in the construction would replace the rqmt not add it.

In general this is no big deal, but for me the values in the baseline rather look like intended replacement values and not added values I just wanted to bring this up, because we might be able to save resources in the future with reducing some of them.

@michelwi
Copy link
Contributor

michelwi commented Feb 8, 2023

I think that is why it is called *_extra_rqmt and not *_rqmt.

I was fully aware of that peculiarity, but agree that this could be surprising. Maybe we add the same parameters but without "extra" and those set the given value?

@Atticus1806
Copy link
Contributor Author

Atticus1806 commented Feb 9, 2023

I agree that the naming is somewhat clear. Maybe adding a docstring would help.
Still I wanted to bring to attention that the default added values like for LS100 is 8, which to me rather seems like this was inteded to be 8 in total.

For example for the ls960 pipeline this value is 6, so here it might be "correct", or is this difference intended?

Maybe @christophmluscher or @JackTemaki can comment?

In general this issue was not about a faulty behavior or necessarily a change, but just to start a discussion on whether this behavior is known/intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants