Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpectrumType.STFT is not correctly serialized #42

Open
albertz opened this issue Dec 7, 2023 · 4 comments
Open

SpectrumType.STFT is not correctly serialized #42

albertz opened this issue Dec 7, 2023 · 4 comments

Comments

@albertz
Copy link
Member

albertz commented Dec 7, 2023

SpectrumType.STFT is not correctly serialized.

Originally posted by @albertz in #41 (comment), @JackTemaki in #41 (comment)

@JackTemaki
Copy link
Contributor

Uhm, I think I was not clear on that one. In "my" code this not correctly serialized. But it was specified that it is okay when "asdict" does not work. I did not test this with "Simons" serialization code which handles exactly these cases. It can be that there it works perfectly fine.

There are already config objects that fail for my code, but this is okay because they came later. I just do not want objects that already existed and that I use to suddenly fail when being serialized, that is all.

I would close this issue until someone check that this is really not serializable in any case.

@albertz
Copy link
Member Author

albertz commented Dec 7, 2023

But you see from your output that it is not correctly serialized?

But it was specified that it is okay when "asdict" does not work.

I don't understand what you mean here.

I did not test this with "Simons" serialization code which handles exactly these cases.

@SimBe195 has specific code to handle enums?

@albertz albertz reopened this Dec 7, 2023
@albertz
Copy link
Member Author

albertz commented Dec 7, 2023

I would leave this issue open until we clarified that this is resolved.

@JackTemaki
Copy link
Contributor

Ah, you are right, it seems this would generally fail. Ok then we can leave this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants