Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GatherLayer resolved wrong common axes #1219

Closed
albertz opened this issue Nov 16, 2022 · 0 comments · Fixed by #1222
Closed

GatherLayer resolved wrong common axes #1219

albertz opened this issue Nov 16, 2022 · 0 comments · Fixed by #1222

Comments

@albertz
Copy link
Member

albertz commented Nov 16, 2022

The code in _get_common_input_position_axes used dict(allow_same_spatial_dim=True). For some different static dim tags which happen to have the same static dim value, this would see them as equal, which is wrong in general.

We could introduce a new behavior version to be more restrict. But this might make it difficult for some people to update?

Or only match auto-generated same spatial/feature dims but never user-generated?

Very related is also #1154 and #865.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant