Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default "from":"data" layer argument, require it explicitly (or default None for layers where it make sense) #519

Closed
albertz opened this issue May 21, 2021 · 2 comments
Closed

Remove default "from":"data" layer argument, require it explicitly (or default None for layers where it make sense) #519

albertz opened this issue May 21, 2021 · 2 comments
Labels
potential-new-behavior Discussions about RETURNN behaviour

Comments

@albertz
Copy link
Member

albertz commented May 21, 2021

#508
@albertz albertz added the potential-new-behavior Discussions about RETURNN behaviour label May 21, 2021
@patrick-wilken patrick-wilken mentioned this issue May 21, 2021
Open
@Zettelkasten Zettelkasten mentioned this issue May 21, 2021
Closed
@albertz albertz mentioned this issue May 21, 2021
Merged
@albertz
Copy link
Member Author

albertz commented May 25, 2021

This here is a case where we do not necessarily need a new behavior_version and instead could just print a deprecation warning.

@JackTemaki JackTemaki mentioned this issue May 31, 2021
Merged
@JackTemaki
Copy link
Collaborator

close with #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
potential-new-behavior Discussions about RETURNN behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albertz @JackTemaki