Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior version? #247

Open
albertz opened this issue Nov 14, 2022 · 0 comments
Open

Behavior version? #247

albertz opened this issue Nov 14, 2022 · 0 comments
Milestone

Comments

@albertz
Copy link
Member

albertz commented Nov 14, 2022

We are already changing some defaults. For example:

As we do not have a stable version yet, this is maybe ok. But we might already think about how to deal with these cases later.

For RETURNN, we have the solution of the behavior version. Specifically, returnn.util.basic.BehaviorVersion in the code, behavior_version flag in the config. See rwth-i6/returnn#508 for some discussions.

We can just introduce the same for returnn-common. Some questions:

  • Should it somehow share something with RETURNN?

    • Even the same global setting? I.e. it means when we need a new behavior version in returnn-common, we need to increase the RETURNN behavior version, and also document it on RETURNN side?
    • Just some code?

    Or alternatively, we would make it decoupled from each other.

  • How would it be configured? There is no config for returnn-common. RETURNN-common can also be executed in various ways, for example inside the Sisyphus manager, or alternatively inside of RETURNN.

    Maybe if inside of RETURNN, we can still set some flag in the RETURNN config for this and use this. So it is part of ReturnnConfig in Sisyphus i6 experiments.

    Otherwise, we can make an assertion that it is explicitly set by the user, via some call returnn_common.set_behavior_version? Or by default it would be behavior version 0 always? (In RETURNN, we made the strong argument that it should not be the latest version by default, otherwise it will break user configs all the time.)

@albertz albertz added this to the first-release milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant