Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate usage before first release #98

Closed
7 of 8 tasks
albertz opened this issue Feb 4, 2022 · 5 comments
Closed
7 of 8 tasks

Intermediate usage before first release #98

albertz opened this issue Feb 4, 2022 · 5 comments
Assignees
Milestone

Comments

@albertz
Copy link
Member

albertz commented Feb 4, 2022

There are still a number of open issues which should be done for the first "official" release (or at least addressed, or maybe deliberately postponed) (#32).

Even before that, I think the current functionality is already in a usable state which could simplify certain things for some applications. E.g. some part of your model or maybe of the loss could already be implemented using RETURNN common.

So, what things are currently blocking us from already using it that way?

What else?

I now just picked things which I see critical before this can be really used. For further things, see #32.

@albertz
Copy link
Member Author

albertz commented Feb 4, 2022

@JackTemaki @Atticus1806 @mmz33 I see us as the first experimental users for this, so I guess we are the ones who should try it out.

@mmz33 e.g. we could implement just the contrastive loss using returnn common.

Or basically any encoder-decoder-attention models should also be quite trivial to implement now.

We also have Conformer and Transformer already (untested...).

@JackTemaki

This comment was marked as off-topic.

@albertz

This comment was marked as off-topic.

@albertz
Copy link
Member Author

albertz commented Mar 1, 2022

Note that if we do not deal with Sis hashes (#51) yet, the naming and descriptions of dim tags will likely become a problem: #119

@albertz
Copy link
Member Author

albertz commented May 5, 2022

I think this can be closed for now. It can already be used, even when not having the Sisyphus hashes solved yet (although you should keep that in mind of course). E.g. you could just handle that manually. Or just use the net dict as hash but then take into consideration that the hash likely will change in the future.

@albertz albertz closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants