Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for spaces in file names #2

Open
s-heppner opened this issue Feb 19, 2024 · 0 comments
Open

Allow for spaces in file names #2

s-heppner opened this issue Feb 19, 2024 · 0 comments

Comments

@s-heppner
Copy link

Currently, the check_part_names() function is used to validate file names, not allowing spaces.

Thanks to @jkhsjdhjs who did the digging:

Validating the filenames via check_part_name() is wrong, as spaces are ASCII characters and thus allowed in filenames.
However, non-ASCII characters still need to be percent-encoded. Thus, the correct way would be to replace the call to check_part_name() by a call to a function that percent-encodes the passed filename, or at least to change the current validation.

This was found due to the bug reported in eclipse-basyx/basyx-python-sdk#236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant