Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive manylinux builds, and drop mimalloc #11

Closed
wants to merge 9 commits into from

Conversation

ayazhafiz
Copy link
Member

Builds development abq binaries on a succifiently-old glibc system,
suitable for dynamic linking of newer glibcs on EC2 and Github Actions.

Drops configuration of mimalloc as the global allocator. Instead, prefer the default system or libc allocator. By default, rustc
will defer to the system allocator.

@ayazhafiz ayazhafiz marked this pull request as ready for review April 5, 2023 14:07
Comment on lines +72 to +74
deprecated-platform: linux_x86-64_glibc
os: linux
architecture: x86_64_glibc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doxavore are you okay with these suffixes? Would you prefer something else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem as sensible to me as anything 🤷

Builds development `abq` binaries on a succifiently-old glibc system,
suitable for dynamic linking of newer glibcs on EC2 and Github Actions.
Instead, prefer the default system or libc allocator. By default, rustc
will defer to the system allocator.
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Bigtest for 209ad18 (run)

Benchmarks:

  • RSpec: 13.77% overhead
    • RSpec time: 17.79 seconds
    • ABQ time: 20.24 seconds
  • RSpec parallel, 10 runs: max 16.13% overhead
    • min 7.59% overhead
    • standard deviation: 2.33%
  • Jest: 6.19% overhead
    • Jest time: 20.708 seconds
    • ABQ time: 21.99 seconds

Fuzz result sizes:

  • PASSED

@ayazhafiz ayazhafiz requested a review from doxavore April 5, 2023 16:30
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Bigtest for 209ad18 (run)

Benchmarks:

  • RSpec: 9.74% overhead
    • RSpec time: 17.77 seconds
    • ABQ time: 19.5 seconds
  • RSpec parallel, 10 runs: max 16.32% overhead
    • min 6.36% overhead
    • standard deviation: 3.68%
  • Jest: 5.22% overhead
    • Jest time: 20.37 seconds
    • ABQ time: 21.434 seconds

Fuzz result sizes:

  • PASSED

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Bigtest for e729c7a (run)

Benchmarks:

  • RSpec: 14.63% overhead
    • RSpec time: 17.77 seconds
    • ABQ time: 20.37 seconds
  • RSpec parallel, 10 runs: max 15.08% overhead
    • min 7.2% overhead
    • standard deviation: 2.26%
  • Jest: 7.20% overhead
    • Jest time: 21.209 seconds
    • ABQ time: 22.736 seconds

Fuzz result sizes:

  • PASSED

@ayazhafiz ayazhafiz marked this pull request as draft April 5, 2023 19:10
Comment on lines +72 to +74
deprecated-platform: linux_x86-64_glibc
os: linux
architecture: x86_64_glibc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem as sensible to me as anything 🤷

@ayazhafiz ayazhafiz closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants