Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build releases as musl-only #16

Merged
merged 1 commit into from Apr 5, 2023
Merged

Build releases as musl-only #16

merged 1 commit into from Apr 5, 2023

Conversation

ayazhafiz
Copy link
Member

@ayazhafiz ayazhafiz commented Apr 5, 2023

ABQ queues can suffer high memory utilization when there are a high number of concurrent requests, which have large payload sizes, presumably due to the ephemeral nature of allocations and increased heap fragmentation. The best behavior for a synthetic, but pathological workload appears to be with a statically-linked musl build, using the default musl allocator.

image

image

image

image

ABQ queues can suffer high memory utilization when there are a high
number of concurrent requests, which have large payload sizes,
presumably due to the ephemeral nature of allocations and increased heap
fragmentation. The best behavior for a synthetic, but pathological
workload appears to be with a statically-linked musl build, using the
default musl allocator.

- [glibc allocator](https://app.datadoghq.com/dashboard/hhb-h26-vmw/abq-queue-monitors?tpl_var_host%5B0%5D=i-06d18347d4cbf8dda&from_ts=1680718736220&to_ts=1680721268896&live=false)
- [jemalloc debug allocator](https://app.datadoghq.com/dashboard/hhb-h26-vmw/abq-queue-monitors?index=&tpl_var_host%5B0%5D=i-0bd039fafb3930233&from_ts=1680717778542&to_ts=1680720455725&live=false)
- [jemalloc](https://app.datadoghq.com/dashboard/hhb-h26-vmw/abq-queue-monitors?index=&tpl_var_host%5B0%5D=i-08960f6a8c02daa9e&from_ts=1680722402333&to_ts=1680723596417&live=false)
- [mimalloc allocator](https://app.datadoghq.com/dashboard/hhb-h26-vmw/abq-queue-monitors?index=&tpl_var_host%5B0%5D=i-016e1dc9cf6d8d02b&from_ts=1680723024490&to_ts=1680724203364&live=false)
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Bigtest for 1ad5426 (run)

Benchmarks:

  • RSpec: 7.71% overhead
    • RSpec time: 17.76 seconds
    • ABQ time: 19.13 seconds
  • RSpec parallel, 10 runs: max 17.62% overhead
    • min 7.66% overhead
    • standard deviation: 2.95%
  • Jest: 4.17% overhead
    • Jest time: 20.346 seconds
    • ABQ time: 21.194 seconds

Fuzz result sizes:

  • PASSED

@ayazhafiz ayazhafiz requested a review from doxavore April 5, 2023 20:40
@TAGraves TAGraves merged commit f40474a into main Apr 5, 2023
17 checks passed
@TAGraves TAGraves deleted the musl-only branch April 5, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants